Skip to Content.
Sympa Menu

sm-discuss - Re: [SM-Discuss] Patches in grimoires

sm-discuss AT lists.ibiblio.org

Subject: Public SourceMage Discussion List

List archive

Chronological Thread  
  • From: Flavien Bridault <vlaaad AT sourcemage.org>
  • To: sm-discuss AT lists.ibiblio.org
  • Subject: Re: [SM-Discuss] Patches in grimoires
  • Date: Tue, 16 May 2006 11:20:44 +0200

Le mardi 16 mai 2006 à 11:10 +0200, Arwed von Merkatz a écrit :
> On Tue, May 16, 2006 at 11:03:09AM +0200, Flavien Bridault wrote:
> > Le lundi 15 mai 2006 à 23:08 -0500, David Kowis a écrit :
> > > Jeremy Blosser wrote:
> > > > On May 15, Daniel Goller [dgoller AT satx.rr.com] wrote:
> > > Automation would be neat, but we'd have to have an application file or
> > > something. Like a file that specifies the order in which patches get
> > > applied.
> > >
> > > It's getting somewhat complicated, but it could be done, and with a well
> > > thought out API, optional patches could be programmed in. (Like a
> > > PATCHES file that uses the patches in the patches dir or somethin)
> > >
> > > apply_patch name.patch
> > > apply_patch othername.patch
> > > optional_patch "what the feck does it do?" y ricer.patch
> > >
> > > or something like that ;)
> > >
> >
> > Why don't we use a mixed approach ? Most of the time sequence numbers
> > for the patch will be ok. Lot of spells use only one patch, some of them
> > two or three which can be applied in any order, and very few cause real
> > problems afaik. In my limited scope (disk, graphics and graphics-libs),
> > I only know the grub spell as a trouble maker.
> > This is a waste of time (and space) imho to add an application file each
> > time. But for the very few annoying spells such as grub, mutt and
> > others, we could have a PATCHES file as David proposed that will
> > override the "default_patch" function.
> > And that would be compliant with the sorcery way of thinking, as we used
> > to do that for other stages, right ?
>
> Please, not yet another file. We have a file for this purpose, it's
> called PRE_BUILD. Any automatic patching could be done in
> default_pre_build.
>
Make sense, so I reformulate : mixed approach with automatic patching
and a way to override that behavior in PRE_BUILD :-)
--
Flavien Bridault

Disk, Graphics, Graphics-libs sections Guru
Source Mage GNU/Linux - http://www.sourcemage.org

irc: vlaaad
jabber: vlaaad AT amessage.be

Attachment: signature.asc
Description: Ceci est une partie de message numériquement signée




Archive powered by MHonArc 2.6.24.

Top of Page