Public SourceMage Discussion List

[Jeremy Blosser <jblosser-smgl AT firinn.org>]

On May 15, Daniel Goller [dgoller AT satx.rr.com] wrote:
> Flavien Bridault wrote:
>>> Le lundi 15 mai 2006 ? 15:38 +0200, Andra?? "ruskie" Levstik a ?crit :
>>>> With my recent work on smgb and smbsd I've found that we have a rather
>>>> incosistent way of handling patches so I was doing some brainstorming on 
>>>> the
>>>> issue(with input from others) and this is what I came up with:
>>>>
>>>> * a directory patches in the spell dir would hold ALL the patches
>>>> * a format for patch filenames would be defined
>>>>   an example: 001-2-mypatch.diff
>>>>   arbitrary:  SEQ-P-NAME.diff
>>>>   SEQ: sequential number from 000-999
>>>>   P: patchlevel
>>>>   NAME: a name for the patch
>>>>   That's for the filename
>>>> * Comments in patches should be defined
>>>>   an example:
>>>>      ***START OF DIFF FILE***
>>>>      ## Description: What does this patch do
>>>>      ## BugUrl: Url to the upstream filed bug about the patch
>>>>      ## Type: [enh|fix|sec|other]
>>>>      THE_PATCH
>>>>      ***END OF DIFF FILE***
>>> Is BugUrl really necessary ? I often make patch by myself when I upgrade
>>> a spell, filling a bug for this is an extra work. Unless this might be
>>> useful to future integration in stable/stable-rc ?
>>> Could also this url points to an another bug managers than our bugzilla,
>>> I mean those from other distros or projects ?
>>>
>>> I would also propose to add the author of the patch. That could be
>>> useful to give some credits to people who create patch, gurus, our
>>> users, apprentices or developers from other projects ?
>>>
> 
> patches if filed upstream helps for bugs to not come back, so while
> being extra work short term, it might pay back in the long run
> 
> if we borrow a patch from glibc bugzilla it would seem logical to
> provide that url there, which would probably also explain the reason for
> the patch better than any short reason we can put

I'm pretty sure the libpatch work that was already done supports patch urls
and such like a regular DETAILS file would.  This conversation really needs
to go back and reference that stuff even if it started a different way.

http://wiki.sourcemage.org/libpatch
http://bugs.sourcemage.org/show_bug.cgi?id=7296

Attachment: pgp4egooShm1l.pgp
Description: PGP signature