Skip to Content.
Sympa Menu

sm-discuss - Re: [SM-Discuss] Patches in grimoires

sm-discuss AT lists.ibiblio.org

Subject: Public SourceMage Discussion List

List archive

Chronological Thread  
  • From: Matthew Clark <MatthewClark AT InLesserTerms.net>
  • To: "Andraž \"ruskie\" Levstik" <ruskie AT mages.ath.cx>
  • Cc: sm-discuss AT lists.ibiblio.org
  • Subject: Re: [SM-Discuss] Patches in grimoires
  • Date: Mon, 15 May 2006 09:22:12 -0500

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

That's a pretty good idea. I'd also like to see a date inside the
patch, or perhaps as part of the filename. Perhaps require the comments
inside the patch file to follow the same format as HISTORY files, and/or
name the files SEQ-P-NAME-YYYYMMDD.diff.

I hadn't thought through it, though. But I like your idea.



- - Matt

Andraž "ruskie" Levstik wrote:
> With my recent work on smgb and smbsd I've found that we have a rather
> incosistent way of handling patches so I was doing some brainstorming on the
> issue(with input from others) and this is what I came up with:
>
> * a directory patches in the spell dir would hold ALL the patches
> * a format for patch filenames would be defined
> an example: 001-2-mypatch.diff
> arbitrary: SEQ-P-NAME.diff
> SEQ: sequential number from 000-999
> P: patchlevel
> NAME: a name for the patch
> That's for the filename
> * Comments in patches should be defined
> an example:
> ***START OF DIFF FILE***
> ## Description: What does this patch do
> ## BugUrl: Url to the upstream filed bug about the patch
> ## Type: [enh|fix|sec|other]
> THE_PATCH
> ***END OF DIFF FILE***
> * If possible ALL patches should be applied in PRE_BUILD
> * Sequential numbers have meaning:
> Patches that should be applied in PRE_BUILD go from 001 to 899
> Patches that can't be applied in PRE_BUILD go from 900 to 999
> 000 is reserved for now
> Other ranges might be added as well I doubt we will ever have 1000 patches
> in a spell
> * Final evolution of this would be automatic patching in PRE_BUILD using
> default_pre_build
>
> Comments, flames, etc...
>
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2.2 (MingW32)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFEaI6U7vwGAOVJvJ8RAgONAKDWNThJw+2TvC0pQUjnMpfJIGpt0QCgjN+v
UrZHiE51IXn1Iah+VGJ68GM=
=9kFm
-----END PGP SIGNATURE-----




Archive powered by MHonArc 2.6.24.

Top of Page