Public SourceMage Discussion List

["Robert Helgesson" <rycee AT home.se>]

On Thu, Apr 08, 2004 at 13:37:12 -0500, Paul wrote:
> This is trickier that it looks at first. You don't want to remove any
> of the dependencies listed in the depends file until after DEPENDS is
> done running. If you remove them first (which is done by cast -r), it
> forgets the past choices.
> 
> Or am I thinking of something else?
> 
> On Thu, 2004-04-08 at 13:20, Robert Helgesson wrote:
> > On Thu, Apr 08, 2004 at 09:52:50 -0700, Eric Sandall wrote:
> > > Quoting Andrew <afrayedknot AT thefrayedknot.armory.com>:
> > > > So to rid a box of gettext i just need to dispel it and do a
> > > > rebuild? I'll try to get that going on a box this week.
> > > 
> > > I believe Sorcery doesn't yet correctly handle removal of optional
> > > dependencies, so when a package is recast with `sorcery rebuild`
> > > that had a dependency on gettext, it may try to resurrect/recast
> > > gettext, if I'm remembering correctly.
> > 
> > Should be easy to fix. A variation of the patch I sent earlier today
> > should do it.

I don't think it would cause any problems. You check if the spell being
depended on still is installed, if it is not then remove the old entry
from the depends file and ask whether the user wants to enable that
dependency or not as per usual.

The private_common_depends function will get proper input regardless and
I don't believe removing the line from depends at that point is a
problem. Perhaps the remove_depends_status function should lock the file
while it's doing the sedit though?

-- 
/     Robert Helgesson     |--    rycee AT home.se     --\
\-- GPG Key ID: 41E95A5B --|   http://www.rycee.cx/   /