Skip to Content.
Sympa Menu

freetds - Re: [freetds] status: documentation

freetds AT lists.ibiblio.org

Subject: FreeTDS Development Group

List archive

Chronological Thread  
  • From: "James K. Lowden" <jklowden AT schemamania.org>
  • To: TDS Development Group <freetds AT lists.ibiblio.org>
  • Subject: Re: [freetds] status: documentation
  • Date: Tue, 23 Dec 2003 19:45:31 -0500

On Tue, 23 Dec 2003, "ZIGLIO Frediano" <Frediano.Ziglio AT vodafone.com>
wrote:
>
> You used a mix of pkddata and data, I changed to use just data (still
> not in CVS... see below)

I'm particularly glad you fixed that wart. But there are a few other
things you're doing that I disagree with. I think my way is better, but
maybe I don't understand.

You have:

if test -e $(DISTRIBUTED_UG_DIR) -a ! -e $(DOCDIR)/userguide ; then \
cp -R $(DISTRIBUTED_UG_DIR) $(DOCDIR); \
fi; \

I had:
if [ -e $(DISTRIBUTED_UG_DIR) -a ! -e $(BUILT_UG_DIR) ]; then \
ln -s $(DISTRIBUTED_UG_DIR) $(BUILT_UG_DIR);\
fi; \

I think creating a symbolic link is more obvious, more reliable, faster,
and conserves disk space.

install-data-local: installdirs $(DOCDIR)/reference/index.html
$(DOCDIR)/userguide/index.htm
$(mkinstalldirs) $(DOCDIR)
if test -e $(DOCDIR)/userguide ; then d=.; else d="$(srcdir)"; fi; \
$(INSTALL_DATA) -c $$d/$(DOCDIR)/userguide/*
$(TARGET_DOCDIR)/userguide

First of all, the test is unnecessary, because the
$(DOCDIR)/userguide/index.htm: target should have created a useful source.
More important, if "test -e $(DOCDIR)/userguide" fails, what guarantee is
there that "$(srcdir)" will contain any HTML?

You have:

install-data-hook:
rm -rf $(TARGET_DOCDIR)

This is bad. After installing the documentation, you delete it?

+++

I'd like to:

1. Use '[', because I think it's fine.
2. Use "ln -s" instead of copying the files to the build directory.
3. Change install-data-local to:

install-data-local: installdirs \
$(DOCDIR)/reference/index.html \
$(DOCDIR)/userguide/index.htm
$(INSTALL_DATA) -c $(DOCDIR)/userguide/* $(TARGET_DOCDIR)/userguide
$(INSTALL_DATA) -c $(DOCDIR)/reference/* $(TARGET_DOCDIR)/reference

4. Remove the install-data-hook target.

Happy to discuss.

--jkl




Archive powered by MHonArc 2.6.24.

Top of Page