FreeTDS Development Group

[Sebastien FLAESCH <sf AT 4js.com>]

Ok will post the patch on SourceForge.

I started to look at it and it appears that many parameters are missing in
the ODBC config, so far I have added these (using src/tds/config.c as ref):

  Instance
  ClientCharset
  ServerCharset
  DumpFile
  DebugFlags
  EmulateLittleEndian
  QueryTimeout
  ConnectionTimeout
  Encryption
  SwapBrokenDates
  SwapBrokenMoney

Note that not all of these are documented... so it would be nice if someone
could tell me which one have to be supported in ODBC.INI ...

Started to hack and now I realize that it would be smarter to have the
src/odbc/connectparams.c module USING the src/tds/config.c module, for
example to reuse the tds_config_encryption() function...

I could also see that the ODBC code repeats the same string constants
several times => candidate for a #define in some header file...

So what kind of patch would be expected in this case?

I mean, I can do a dirty/small patch or a large/smart patch ...

Maybe I am too new to this project to make large changes, so I better let
you guys make it nicer once posted...

Also, are there any test cases I should add / adapt (I could not find
anything in src/odbc/unittests reading an odbc.ini file)

Seb

James K. Lowden wrote:
> Sebastien FLAESCH wrote:
> > Anything I need to known to create a patch proposal?
>
> Universal diff against CVS HEAD is best unless the patch applies only to a
> branch.  See also doc/CodingStyle. 
>
> The more work you do to make the patch apply cleanly and to adhere to the
> style, the less work is left for us.  That makes us happier!  ;-)  But
> I've never turned down a patch for bad formatting; I just clean it up and
> apply it. 
>
> > Just created an account at sourceforge, did a cvs checkout with
> > anonymous user...
>
> Excellent!  
>
> > Should I send the diff to this mailingt list when done?
>
> It's a little better to upload the patch to SF, where it won't get lost
> and where people can see it.  But if you're paying attention and you know
> we're looking for it because it addresses something recently discussed
> here, then just posting it to the ML is fine.  
>
> The main difference is that patches queue up at SF and don't get lost. 
> Whenever one of us has time, we clear the queue.  If it's posted to the
> ML, it's a good idea to monitor its progress and to post a reminder if you
> don't see some kind of action in a week of so.  
>
> Welcome, Sebastien!  We look forward to your patch.  
>
> Regards, 
>
> --jkl
> _______________________________________________
> FreeTDS mailing list
> FreeTDS AT lists.ibiblio.org
> http://lists.ibiblio.org/mailman/listinfo/freetds