Bugs for Sorcery are reported here

[bugzilla-daemon AT bugs.sourcemage.org]

http://bugs.sourcemage.org/show_bug.cgi?id=13938





--- Comment #21 from Andraž 'ruskie' Levstik <ruskie+bugs AT codemages.net>  
2009-09-28 05:43:17 ---
(In reply to comment #20)
> 1.(9.1) But it hasn't happened yet. It's just about keeping feature parity 
> with
> nonhooked sorcery. I'm not sure adding a separate spell for what, 30 lines 
> of
> code makes sense. The transition wouldn't be trivial too.
> 

Let me be more precise in my wording:

I would get rid of them completly... obliterate them etc. They would not get
installed would not exist and so on.

Instead just hooks with the relevant calls would be. Just like the mail hook 
is
now. No special function for it.

> 3. It would. A local var of a function is available as a global to the
> functions that function calls.
> 

Ahh.

> 4. It is mostly handled outside, but it is generated in that function.
> 

Ahh

> 10.5 All the hooks except cast_final are tied to one spell, so all those 
> would
> be fine with redefinition. cast_final spoils the party, as it may depend on
> spells doing special things in other hooks and then manipulating that info. 
> If
> it started being used in the middle of a cast, only the subsequent spells 
> would
> provide that info. If this hook was left out of the redefinition, the other
> hooks may create files and other crap expecting cast_final to use it and 
> clean
> it up. :/
> 

Good point. But hooks should not break the system. If a hook fails it should 
do
so silently. Or maybe need to add a hooks.log to store what's happening with
them.

> Oh, why isn't there a "cast_initial"?

Hmmm good point... but where to put it? before the check in cast if it's
running as a user? after that? Before munging on the params? After?

-- 
Configure bugmail: http://bugs.sourcemage.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.