Bugs for Sorcery are reported here

[bugzilla-daemon AT bugs.sourcemage.org]

http://bugs.sourcemage.org/show_bug.cgi?id=13938





--- Comment #16 from Jaka Kranjc <svn AT lynxlynx.info>  2009-09-25 15:14:24 ---
1. Those two settings should stay, so you're not forced to use whatever the
code decides.

2. Think of the user. How likely is she to know that that call happens in an
equally named function for each building spell instead of at the start of cast
(global).

3. If you mean you want to expose more internals in no solidly defined manner,
then I say you need to put most of the calls in the functions even more.

4. It is inconsistent. In this case the inlining would fix it, but I think I
saw some others too.

5. They don't need all four hooks for that.

8. Corrupted? Missing?

9. It is more effort if you have to source the file each time, not less. And
you yourself claim the lib is not important, so where's the problem (except 
for
the overridability)?

ad) Stuff should not install in the sorcery dir. If you want the user to be
able to edit something, it should be done in the config dir.

10. With functions the user would not need to know any more bash than usual.
The default hook lib would define just the used hooks and the others are
documented, so it is a quick copy/paste job to add a new hook. Removing is no
harder nor simpler.

ad)An elegant approach has better chances of being accepted. The current 
method
does not meet that criterion, there just too many redundant files.

-1. Which of these hooks do you actually use and for what?

-- 
Configure bugmail: http://bugs.sourcemage.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.