Bugs for Sorcery are reported here

[bugzilla-daemon AT bugs.sourcemage.org]

http://bugs.sourcemage.org/show_bug.cgi?id=13938





--- Comment #14 from Jaka Kranjc <svn AT lynxlynx.info>  2009-09-25 09:31:25 ---
I meant the part where you don't set the term title according to spell
success/failure.

USE_HOOKS won't fallback to "on" if the var is already set and empty.

cast_spell would be better named cast_spell_start or just spell_start. ?

Most if not all of the calls that go through run_spell_file could be made in 
it
instead.

There is some inconsistency on when you use hooks or not - eg. BUILD always 
has
them, while CONFLICTS just if the file is there.

*_DOWNLOAD is probably not needed. It also suggest it is run before/after
DOWNLOAD, but that is not completely true.

I'm also not sure DETAILS and PRE_SUB_DEPENDS should be there, since these
files get run multiple times per spell.

I don't see how any hook could work, since they are in subdirs of what you are
looking at.

libhook has some bad comments.

libhook should be available to the hooks directly, so they don't need to 
source
it.

Infact the design should be more flexible to allow for custom libraries.
libhook should maybe just disappear, there is no way the users can modify it.
The hooks should be read from some othe path.

It would be better to have hooks as functions (similar to run_spell_file), so
the spell/user would only need to modify one file (the libhooks) and most of
the centuplication would be gone. The file would be read on startup and then
the respective functions would be called as needed.

-- 
Configure bugmail: http://bugs.sourcemage.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.