Skip to Content.
Sympa Menu

sm-sorcery-bugs - [SM-Sorcery-Bugs] [Bug 13938] Hooks support in sorcery...

sm-sorcery-bugs AT lists.ibiblio.org

Subject: Bugs for Sorcery are reported here

List archive

Chronological Thread  
  • From: bugzilla-daemon AT bugs.sourcemage.org
  • To: sm-sorcery-bugs AT lists.ibiblio.org
  • Subject: [SM-Sorcery-Bugs] [Bug 13938] Hooks support in sorcery...
  • Date: 25 Sep 2009 09:50:53 -0000

http://bugs.sourcemage.org/show_bug.cgi?id=13938


Andraž 'ruskie' Levstik <ruskie+bugs AT codemages.net> changed:

What |Removed |Added
----------------------------------------------------------------------------
Attachment #7368|0 |1
is obsolete| |




--- Comment #12 from Andraž 'ruskie' Levstik <ruskie+bugs AT codemages.net>
2009-09-25 04:50:52 ---
Created an attachment (id=7369)
--> (http://bugs.sourcemage.org/attachment.cgi?id=7369)
hooks.diff

> examples should be put in a spell, only what we already use should stay.
> This
> coupled with unrelated changes makes the patch harder to review.

Pulled it out.

> Leaving the term title alone, you'll have problems with cast_final changing
> current behaviour.

Can you elaborate?

> why do you have DOWNLOAD hooks twice? Also post_TRIGGER_CHECK is double.
Fixed. The duplicates were meant for two extra hooks, the other one I'm not
sure why but I'll see if I notice anything missing.

> You don't run post_CONFLICTS.
Added

> rename HOOK to USE_HOOKS for clarity and to avoid any possible future
> clashes.
Done

> looks like you did a bad merge of run_install.
Yeah had issues there. I hope I fixed it now.

--
Configure bugmail: http://bugs.sourcemage.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



Archive powered by MHonArc 2.6.24.

Top of Page