Bugs for Sorcery are reported here

[bugzilla-daemon AT bugs.sourcemage.org]

http://bugs.sourcemage.org/show_bug.cgi?id=13565





------- Additional Comments From jupp AT physik.uni-potsdam.de  2007-02-26 10:09 
-------
(In reply to comment #4)
> (In reply to comment #3)
> > (In reply to comment #1)
> > > Thank you for tracking down the cause of the failure.
> > > 
> > > I disagree with your patch because it fixes merely a symptom of the
problem, and
> > > not the actual problem. Instead failglob should either be explicitly 
> > > disabled,
> > > or the leak through which failglob got enabled in cast's environment 
> > > should be
> > > closed. 
> > 
> > Funny, I would say it is the other way round: unsetting failglob is just
> > covering up the symptoms (bash will then silently ignore the non-match).
> 
> The code handles this situation other ways. It is not necessary to have it 
> on.
> Sorcery already handles glob failures by checking for emptiness or having 
> loops.

I tried to point out one place where it doesn't (lines where $STD_DEBUG
is expanded).

> 
> So your argument is that its a debugging feature. 

Yes.

> Therefore we should use it.

No.
My argument is that I used it and it detected a potential problem.

> Unlike -W, which causes gcc to PRINT warnings, this causes the code to HALT.

I like that (and I can switch it off if needs be), but that's not the point.
I did not suggest to switch on failglob; I suggested to fix the problem.



-- 
Configure bugmail: http://bugs.sourcemage.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.