Skip to Content.
Sympa Menu

sm-commit - Re: [SM-Commit] GIT changes to master grimoire by George Sherwood (dd2b0a57e330df2975e0d0c9bae9a41b8320aa53)

sm-commit AT lists.ibiblio.org

Subject: Source Mage code commit list

List archive

Chronological Thread  
  • From: "Eric Sandall" <eric AT sandall.us>
  • To: sm-commit AT lists.ibiblio.org
  • Subject: Re: [SM-Commit] GIT changes to master grimoire by George Sherwood (dd2b0a57e330df2975e0d0c9bae9a41b8320aa53)
  • Date: Fri, 21 Nov 2008 16:29:27 -0800

Quoting "George Sherwood" <pilot AT beernabeer.com>:

On Fri, 21 Nov 2008 15:50:20 -0800
"Eric Sandall" <eric AT sandall.us> wrote:
<snip>
I believe one of the requirements for a commit is that it was tested
and works with the default version (and default settings) of a
package. ;)

Well if I had known that I would have done no bug fixing today. :) I
surely am not going to downgrade all my machines to build gamin against
glibc 2.7. Luckily I had one that I hadn't updated.

Yeah, that makes testing a PITA when we're working on a newer version of a package (especially something as core as glibc), but that requirement is there for a reason. :)

For me, I don't expect developers to have a default install of every package on their system (chroot, VM, whatnot) just to test, but I think that the package being modified should be tested with the defaults before being committed. This way you only have to worry about one package (at a time) being default. Yeah, for modifying packages like glibc this would be a lot of work to switch between. I don't expect you to have all of GNOME set to the default when testing glibc, but at least have glibc set to default. ;)

-sandalle

--
Eric Sandall | Source Mage GNU/Linux Developer
eric AT sandall.us PGP: 0xA8EFDD61 | http://www.sourcemage.org/
http://eric.sandall.us/ | http://counter.li.org/ #196285





Archive powered by MHonArc 2.6.24.

Top of Page