Source Mage code commit list

[George Sherwood <pilot AT beernabeer.com>]

On Fri, 21 Nov 2008 15:50:20 -0800
"Eric Sandall" <eric AT sandall.us> wrote:

> Quoting "George Sherwood" <pilot AT beernabeer.com>:
> 
> > On Fri, 21 Nov 2008 13:25:19 -0800
> > "Eric Sandall" <eric AT sandall.us> wrote:
> >
> >> Quoting "George Sherwood" <scm AT sourcemage.org>:
> >>
> >> > GIT changes to master grimoire by George Sherwood
> >> > <gsherwood AT sourcemage.org>:
> >> >
> >> >  utils/gamin/HISTORY   |    3 +++
> >> >  utils/gamin/PRE_BUILD |    4 ++++
> >> >  2 files changed, 7 insertions(+)
> >> >
> >> > New commits:
> >> > commit dd2b0a57e330df2975e0d0c9bae9a41b8320aa53
> >> > Author: George Sherwood <gsherwood AT sourcemage.org>
> >> > Commit: George Sherwood <gsherwood AT sourcemage.org>
> >> >
> >> >     gamin: Added fix for glibc 2.8 from Bug #14859.
> >> >
> >> > diff --git a/utils/gamin/HISTORY b/utils/gamin/HISTORY
> >> > index 1bbfeb6..d608cda 100644
> >> > --- a/utils/gamin/HISTORY
> >> > +++ b/utils/gamin/HISTORY
> >> > @@ -1,3 +1,6 @@
> >> > +2008-11-21 George Sherwood <gsherwood AT sourcemage.org>
> >> > +        * PRE_BUILD: Added fix for glibc 2.8. Bug #14859
> >> > +
> >> >  2008-02-17 Vlad Glagolev <stealth AT sourcemage.org>
> >> >          * DEPENDS: added automake as a req dep -- gamin strictly
> >> >            depends on it, cleaned up
> >> > diff --git a/utils/gamin/PRE_BUILD b/utils/gamin/PRE_BUILD
> >> > index 78ca95a..00137dd 100755
> >> > --- a/utils/gamin/PRE_BUILD
> >> > +++ b/utils/gamin/PRE_BUILD
> >> > @@ -1,3 +1,7 @@
> >> >  default_pre_build      &&
> >> >  cd  $SOURCE_DIRECTORY  &&
> >> > +
> >> > +#Fix for glibc 2.8 from Bug 14859
> >> > +sed "s/^AC_ISC_POSIX$/AC_USE_SYSTEM_EXTENSIONS/" -i
> >> > configure.in && +
> >> >  autoreconf
> >>
> >> The 2.8 fix is okay to apply to 2.7? I see in the bug that
> >> AC_ISC_POSIX is deprected, so I assume the new one will work, but
> >> wanted to verify it was tested. :)
> >>
> >
> > I don't have a machine runing glibc so it wasn't tested.  I usually
> > don't test against multiple versions of dependencies.
> 
> I believe one of the requirements for a commit is that it was tested  
> and works with the default version (and default settings) of a  
> package. ;)
> 
> 


Well if I had known that I would have done no bug fixing today. :)  I
surely am not going to downgrade all my machines to build gamin against
glibc 2.7.  Luckily I had one that I hadn't updated.

George

-- 
George Sherwood
Source Mage GNU/Linux Lead Developer
http://www.sourcemage.org

Attachment: signature.asc
Description: PGP signature