Skip to Content.
Sympa Menu

sm-commit - Re: [SM-Commit] PERFORCE change 80208 by Daniel Goller for review

sm-commit AT lists.ibiblio.org

Subject: Source Mage code commit list

List archive

Chronological Thread  
  • From: Jeremy Blosser <jblosser-smgl AT firinn.org>
  • To: SM-Commit Daemon <sm-commit AT lists.ibiblio.org>
  • Subject: Re: [SM-Commit] PERFORCE change 80208 by Daniel Goller for review
  • Date: Mon, 5 Jun 2006 13:56:46 -0500

On Jun 05, Eric Sandall [eric AT sandall.us] wrote:
> Perforce Review Daemon wrote:
> > Differences ...
> <snip>
> > @@ -1,3 +1,8 @@
> > +2006-06-04 Daniel Goller <morfic AT sourcemage.org>
> > + * DEPENDS: remove -stl/-no-stl flags from optional stlport depend to
> > avoid turning off STL support
> > + * BUILD: add -stl to configure to ensure building with STL support,
> > + fixes build errors with celestia and scribus that depend on it
> > +
> > 2006-05-22 Treeve Jelbert <treeve01 AT pi.be>
> > * DETAILS: Updated to 4.1.3
> > * BUILD: remove invoke_gcc ( done in default_pre_build)
>
> People will probably complain about this, but I think you should add
> PATCHLEVEL in DETAILS so that qt4 is recompiled with this option so STL
> is enabled for celestia and scribus, otherwise people will have to just
> 'know' they need to recompile to get these fixes rather than having it
> automagic.

If it weren't qt, maybe, but that thing takes forever. Not having this
change does not break any existing installs, if they were "broken" before
only then do they need it.

This one is probably on the border but because it is and because qt is huge
I'm going to argue "no, let the local admin manage it themselves".

Attachment: pgpxUX9eGe0F_.pgp
Description: PGP signature




Archive powered by MHonArc 2.6.24.

Top of Page