Skip to Content.
Sympa Menu

sm-commit - Re: [SM-Commit] PERFORCE change 80208 by Daniel Goller for review

sm-commit AT lists.ibiblio.org

Subject: Source Mage code commit list

List archive

Chronological Thread  
  • From: Eric Sandall <eric AT sandall.us>
  • To: SM-Commit Daemon <sm-commit AT lists.ibiblio.org>
  • Subject: Re: [SM-Commit] PERFORCE change 80208 by Daniel Goller for review
  • Date: Mon, 05 Jun 2006 11:41:53 -0700

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Perforce Review Daemon wrote:
> Change 80208 by daniel_goller@daniel_goller on 2006/06/04 23:54:27
>
> always enabling STL support to allow celestia and scribus to build
> properly, if we do not want to use external stlport
>
> Affected files ...
>
> ... //sgl/grimoires/devel/x11-toolkits/qt4/BUILD#4 edit
> ... //sgl/grimoires/devel/x11-toolkits/qt4/CONFIGURE#2 edit
> ... //sgl/grimoires/devel/x11-toolkits/qt4/DEPENDS#2 edit
> ... //sgl/grimoires/devel/x11-toolkits/qt4/DETAILS#6 edit
> ... //sgl/grimoires/devel/x11-toolkits/qt4/HISTORY#10 edit
> ... //sgl/grimoires/devel/x11-toolkits/qt4/INSTALL#4 edit
> ... //sgl/grimoires/devel/x11-toolkits/qt4/PROVIDES#2 edit
> ... //sgl/grimoires/devel/x11-toolkits/qt4/qt.sh#2 edit
>
> Differences ...
<snip>
> @@ -1,3 +1,8 @@
> +2006-06-04 Daniel Goller <morfic AT sourcemage.org>
> + * DEPENDS: remove -stl/-no-stl flags from optional stlport depend to
> avoid turning off STL support
> + * BUILD: add -stl to configure to ensure building with STL support,
> + fixes build errors with celestia and scribus that depend on it
> +
> 2006-05-22 Treeve Jelbert <treeve01 AT pi.be>
> * DETAILS: Updated to 4.1.3
> * BUILD: remove invoke_gcc ( done in default_pre_build)

People will probably complain about this, but I think you should add
PATCHLEVEL in DETAILS so that qt4 is recompiled with this option so STL
is enabled for celestia and scribus, otherwise people will have to just
'know' they need to recompile to get these fixes rather than having it
automagic.

- -sandalle

- --
Eric Sandall | Source Mage GNU/Linux Developer
eric AT sandall.us | http://www.sourcemage.org/
http://eric.sandall.us/ | SysAdmin @ Shock Physics @ WSU
http://counter.li.org/ #196285 | http://www.shock.wsu.edu/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.3 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFEhHrxHXt9dKjv3WERAnR2AJ0Z0JtJe7egQvU6IlmOpFVXc18jDwCgjMpd
M4NXoQSBsiZZ2+u/zAOdYqU=
=6w01
-----END PGP SIGNATURE-----




Archive powered by MHonArc 2.6.24.

Top of Page