freetds AT lists.ibiblio.org
Subject: FreeTDS Development Group
List archive
- From: James K. Lowden <jklowden AT speakeasy.org>
- To: "TDS Development Group" <freetds AT franklin.oit.unc.edu>
- Subject: Re: Coding style document
- Date: Sun, 16 Jun 2002 16:18:14 -0400
On Thu, 13 Jun 2002 17:18:43 -0500, "Sam Denton" <denton AT wantec.com>
wrote:
> > From: Lowden, James K [mailto:LowdenJK AT bernstein.com]
> > Sent: Thursday, June 13, 2002 2:34 PM
> >
> > Brian, on that point, many functions in tds/convert.c pass "src" or
> > "dest" unnecessarily. It's as though at one point there might have
> > been an intention to make all the conversion functions conform to a
> > single signature. Was there any such goal? If not, I'd like to
> > remove the unused parameters.
> Without looking at the code, there are lots of cases where one wants to
> store function pointers in an array or something. To avoid typecasts,
> you need to give the functions the same signature, and learn to live
> with the compiler's complaints about unused parameters.
Yes, but with looking at the code :) I can't find any such array. If
there isn't any intention to create one, I'd like to remove the unused
arguments. Clean code attracts good hackers.
--jkl
-
Re: Coding style document
, (continued)
- Re: Coding style document, Dossy, 06/13/2002
- Re: Coding style document, Lowden, James K, 06/13/2002
- Re: Coding style document, Dossy, 06/13/2002
- Re: Coding style document, Sam Denton, 06/13/2002
- Re: Coding style document, James K . Lowden, 06/13/2002
- Re: Coding style document, James K . Lowden, 06/13/2002
- Re: Coding style document, Winkless, Geoff, 06/14/2002
- Re: Coding style document, Dossy, 06/14/2002
- Re: Coding style document, ZIGLIO Frediano, 06/14/2002
- Re: Coding style document, Brian Bruns, 06/14/2002
- Re: Coding style document, James K . Lowden, 06/16/2002
Archive powered by MHonArc 2.6.24.