Skip to Content.
Sympa Menu

freetds - [PATCH] goodread() fix *re-submitted*

freetds AT lists.ibiblio.org

Subject: FreeTDS Development Group

List archive

Chronological Thread  
  • From: Steve Willer <willer AT novator.com>
  • To: freetds AT franklin.metalab.unc.edu
  • Subject: [PATCH] goodread() fix *re-submitted*
  • Date: Thu, 14 Mar 2002 15:01:28 -0500 (EST)



Way back months ago, I sent in a fix for a bug in goodread()'s usage of
READ:

while (got < buflen) {
got += READ(tds->s, buf + got, buflen - got);
}

That fix isn't perfect, and in fact later that day I sent another version
of it that worked better and detected errors. Unfortunately, whoever
inserted the fix only put in the first version and missed the rest.

Could someone please put the proper fix into src/tds/read.c, around line
91? Here it is, below:

while (got < buflen) {
int thisgot;
thisgot = READ(tds->s, buf + got, buflen - got);
if (thisgot <= 0) break;
got += thisgot;
}

Thanks.





Archive powered by MHonArc 2.6.24.

Top of Page