freetds AT lists.ibiblio.org
Subject: FreeTDS Development Group
List archive
- From: Steve Willer <willer AT novator.com>
- To: TDS Development Group <freetds AT franklin.metalab.unc.edu>
- Subject: Re: [PATCH] goodread() fix *re-submitted*
- Date: Tue, 19 Mar 2002 15:26:30 -0500 (EST)
On Thu, 14 Mar 2002, Steve Willer wrote:
> while (got < buflen) {
> int thisgot;
> thisgot = READ(tds->s, buf + got, buflen - got);
> if (thisgot <= 0) break;
> got += thisgot;
> }
In this patch, shouldn't the line:
if (thisgot <= 0) break;
actually be:
if (thisgot <= 0) return -1;
?
This seems more correct, because tds_read_packet() expects a -1 in an
error situation. I think we're actually experiencing the inf-loops caused
by this bug in error handling (we're using the patch locally).
-
[PATCH] goodread() fix *re-submitted*,
Steve Willer, 03/14/2002
- <Possible follow-up(s)>
- Re: [PATCH] goodread() fix *re-submitted*, James Cameron, 03/14/2002
- Re: [PATCH] goodread() fix *re-submitted*, Steve Willer, 03/18/2002
- Re: [PATCH] goodread() fix *re-submitted*, Brian Bruns, 03/18/2002
- Re: [PATCH] goodread() fix *re-submitted*, Steve Willer, 03/19/2002
- Re: [PATCH] goodread() fix *re-submitted*, James Cameron, 03/19/2002
- Re: [PATCH] goodread() fix *re-submitted*, Steve Willer, 03/20/2002
- Re: [PATCH] goodread() fix *re-submitted*, Brian Bruns, 03/20/2002
Archive powered by MHonArc 2.6.24.