freetds AT lists.ibiblio.org
Subject: FreeTDS Development Group
List archive
- From: "Mark J. Lilback" <mark AT lilback.com>
- To: freetds mailing list <freetds AT franklin.oit.unc.edu>
- Subject: some more changes
- Date: Thu, 8 Nov 2001 12:53:54 -0500
I've checked in a few more minor changes (adding parameters to message handler declarations, return statements that were implied, etc.).
include/cspublic.h
include/tds_util.h
src/dblib/bcp.c
src/dblib/dbutil.c
src/tds/write.c
Here are a few I wanted to ask about before checking in:
1) Why aren't the severity levels listed in sybfront.h? I've copied them over from SQL Server's sybfront.h file. Any reason not to check this in?
2) Here's a diff that I can commit... any problem with this one?
*** src/tds/config.c 2001/10/24 23:19:44 1.3
--- src/tds/config.c 2001/11/08 17:54:19
***************
*** 313,319 ****
}
static void tds_config_login(TDSCONFIGINFO *config, TDSLOGIN *login)
{
! if (strlen(login->server_name)) {
if (config->server_name) free(config->server_name);
config->server_name = strdup(login->server_name);
}
--- 313,319 ----
}
static void tds_config_login(TDSCONFIGINFO *config, TDSLOGIN *login)
{
! if (login->server_name && strlen(login->server_name)) {
if (config->server_name) free(config->server_name);
config->server_name = strdup(login->server_name);
}
***************
*** 321,351 ****
config->major_version = login->major_version;
config->minor_version = login->minor_version;
}
! if (strlen(login->language)) {
if (config->language) free(config->language);
config->language = strdup(login->language);
}
! if (strlen(login->char_set)) {
if (config->char_set) free(config->char_set);
config->char_set = strdup(login->char_set);
}
! if (strlen(login->host_name)) {
if (config->host_name) free(config->host_name);
config->host_name = strdup(login->host_name);
}
! if (strlen(login->app_name)) {
if (config->app_name) free(config->app_name);
config->app_name = strdup(login->app_name);
}
! if (strlen(login->user_name)) {
if (config->user_name) free(config->user_name);
config->user_name = strdup(login->user_name);
}
! if (strlen(login->password)) {
if (config->password) free(config->password);
config->password = strdup(login->password);
}
! if (strlen(login->library)) {
if (config->library) free(config->library);
config->library = strdup(login->library);
}
--- 321,355 ----
config->major_version = login->major_version;
config->minor_version = login->minor_version;
}
! if (login->language && strlen(login->language)) {
if (config->language) free(config->language);
config->language = strdup(login->language);
}
! if (login->char_set && strlen(login->char_set)) {
if (config->char_set) free(config->char_set);
config->char_set = strdup(login->char_set);
}
! if (login->host_name && strlen(login->host_name)) {
if (config->host_name) free(config->host_name);
config->host_name = strdup(login->host_name);
+ /* should work with IP (mlilback, 11/7/01) */
+ if (config->ip_addr) free(config->ip_addr);
+ config->ip_addr = calloc(sizeof(char),18);
+ lookup_host(config->host_name, NULL, config->ip_addr, NULL);
}
! if (login->app_name && strlen(login->app_name)) {
if (config->app_name) free(config->app_name);
config->app_name = strdup(login->app_name);
}
! if (login->user_name && strlen(login->user_name)) {
if (config->user_name) free(config->user_name);
config->user_name = strdup(login->user_name);
}
! if (login->password && strlen(login->password)) {
if (config->password) free(config->password);
config->password = strdup(login->password);
}
! if (login->library && strlen(login->library)) {
if (config->library) free(config->library);
config->library = strdup(login->library);
}
***************
*** 382,388 ****
{
char *s;
char path[255];
! pid_t pid;
if (s=getenv("TDSDUMP")) {
if (!strlen(s)) {
--- 386,392 ----
{
char *s;
char path[255];
! pid_t pid=0;
if (s=getenv("TDSDUMP")) {
if (!strlen(s)) {
--
__________________________________________________________________________
"They that can give up essential liberty
Mark J. Lilback to obtain a little temporary safety
<mark AT lilback.com> deserve neither liberty or safety."
http://www.lilback.com/ -- Benjamin Franklin
-
some more changes,
Mark J. Lilback, 11/08/2001
- <Possible follow-up(s)>
- Re: some more changes, Brian Bruns, 11/08/2001
Archive powered by MHonArc 2.6.24.