Skip to Content.
Sympa Menu

sm-sorcery-bugs - [SM-Sorcery-Bugs] [Bug 10508] KERNELS spell file for kernel config checks

sm-sorcery-bugs AT lists.ibiblio.org

Subject: Bugs for Sorcery are reported here

List archive

Chronological Thread  
  • From: bugzilla-daemon AT bugs.sourcemage.org
  • To: sm-sorcery-bugs AT lists.ibiblio.org
  • Subject: [SM-Sorcery-Bugs] [Bug 10508] KERNELS spell file for kernel config checks
  • Date: 8 Feb 2006 21:54:59 -0000

http://bugs.sourcemage.org/show_bug.cgi?id=10508


acedit AT armory.com changed:

What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution| |INVALID




------- Additional Comments From acedit AT armory.com 2006-02-08 15:54 -------
I realize that code organization can be important, but I think sorcery is too
low of a level. There are other answers to this problem. Inline comment go a
long way. As does having a policy setup within the grimoire team on where/how
certain tasks are done. We've solved a bunch of problems this way without
having
to bring sorcery into it (for example, spells with an option of using cvs).

Note that you are also free to run/source files from other files. So, a spell
file could load another spell file if it wanted (look at the linux spell), or
kernel specific functions that reside in FUNCTIONS could live in another
library
file and be sourced by FUNCTIONS, or, could reside in just the kernel
section's
section level FUNCTION file away from the common grimoire-wide stuff.

There are also backwards compatibility problems with adding new spell files.
Specifically, most spells cannot use the new file until the sorcery that
implements it is released as stable, this process is not always very fast, nor
can we force people to upgrade immediatly either.

Hypothetically, if the file were to be added, what phase of cast would it be
run
at? the dependency resolution phase, or the build phase? In former I think it
would just be a confusing adjunct to CONFIGURE/DEPENDS, what if a kernel
configuration option affected something in CONFIGURE or DEPENDS? what if a
dependency choice effected a kernel config requirement? Theres no good answer
for where to run the file (before CONFIGURE, between CONFIGURE and DEPENDS, or
after DEPENDS). If its run in the build phase and its checking for certain
options, it may be too late to accomplish certain things that can only be done
at depends resolution, not to mention, having part of PRE_BUILD segmented off
to
a seperate file seems kind of confusing. More places to look for where things
are happening.

That said, I dont see a good enough argument to merit the addition of a new
file
to be supported by sorcery. So Im going to mark this INVALID, in agreement
with
David (who I'll note is both a sorcery team member and the primary maintainer
of
the linux spell).

Lastly, pedantic point: spell files for which FUNCTIONS is not loaded
automatically are free to load it themselves. "source $GRIMOIRE/FUNCTIONS" is
pretty trivial. Or, they could load some other grimoire library.

--
Configure bugmail: http://bugs.sourcemage.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.




Archive powered by MHonArc 2.6.24.

Top of Page