Skip to Content.
Sympa Menu

sm-discuss - Re: [SM-Discuss] Spell branches

sm-discuss AT lists.ibiblio.org

Subject: Public SourceMage Discussion List

List archive

Chronological Thread  
  • From: Ismael Luceno <ismael.luceno AT gmail.com>
  • To: sm-discuss AT lists.ibiblio.org
  • Subject: Re: [SM-Discuss] Spell branches
  • Date: Tue, 13 Sep 2011 04:34:15 -0300

El Tue, 13 Sep 2011 08:26:09 +0900
flux <flux AT sourcemage.org> escribió:
<...>
> A slightly improved version of the code is as follows:
>
> function select_branch() {
> local spell="$1" tmp &&
> shift &&
>
> if [[ "$#" > 1 ]]; then
> config_query_list "$spell"_BRANCH \
> "Select one of the available branches:" "$@"
> else
> eval "$spell"_BRANCH=\""$spell"\"
> fi &&
>
> eval tmp=\"\$"$spell"_BRANCH\" &&
>
> if [[ "$tmp" != "$spell" && "${tmp/-*}" = "scm" ]]; then
> config_query "$spell"_SCM_AUTOUPDATE \
> 'Update on every system update?' n
> fi
> }
>
> This is more "correct" in that a spell named scm-foo wouldn't
> erroneously trigger the second if block to succeed. It's also a bit
> more readable in how tmp gets set (and uses the "$spell" variable
> instead of $1, so the value is more readable as well).

$1 != $spell, 3rd line.

Attachment: signature.asc
Description: PGP signature




Archive powered by MHonArc 2.6.24.

Top of Page