Public SourceMage Discussion List

[Vlad Glagolev <stealth AT sourcemage.org>]

We have a lot of annoying things here.

First of all: spaces.

Things like:

--
optional_depends very-long-spell-name-or-not  \
                 "--enable-foo"               \
                 "--disable-foo"              \
                 "for foo feature"            &&
--

are damn useless, and it's hard to fix it every time, when some more 
dependencies were added, or description of the dependency, and so on.
It's very hard/time-consuming to go through the jungles of spaces while 
editing the spell's deps or add new ones.

I'd offer to just remove (and don't add) unneeded spaces here:

-
optional_depends spell \
                 "--with-feature" \
                 "--without-feature" \
                 "for some kind of feature support" &&
--

Next, newlines.

--
depends xproto &&
depends fontconfig &&
depends libx11
--

is ok, but I think, depends block should be separated from optional_depends 
block by new line, and all optional_depends blocks should be separated by new 
line from each other.

Also:

--
optional_depends spell \
                 "--with-foo" \
                 "--without-foo" \
                 "for foo support" &&
--

is ok, like this:

--
optional_depends spell \
                 "--with-foo" "-without-foo" \
                 "for foo support" &&
--

and like this:

--
optional_depends spell "" "" "some pythonic spell with no actual configure 
flags"
--

Comments?

-- 
Dont wait to die to find paradise...
--
Cheerz,
Vlad "Stealth" Glagolev

Attachment: pgpsJ39F9nHN_.pgp
Description: PGP signature