Public SourceMage Discussion List

["David Brown" <dmlb2000 AT gmail.com>]

This is a commit I did for the last maintenance patch update. I'd like
to point out the history diff and suggest changing the format of the
date to `date --rfc-3339=seconds` this command adds the time down to
seconds and the timezone offset.  Adding those two components changes
the diff to appear a little more what it was intended to be.

On 5/24/07, David Brown <scm AT sourcemage.org> wrote:
> GIT changes to master grimoire by David Brown <dmlb2000 AT gmail.com>:
>
>  kernels/linux/HISTORY                                         |    4 ++++
>  kernels/linux/info/patches/maintenance_patches/patch-2.6.21.2 |    6 ++++++
>  kernels/linux/latest.defaults                                 |    2 +-
>  3 files changed, 11 insertions(+), 1 deletion(-)
>
> New commits:
> commit d705d092a564585fc2c580cd38f64780c2f6c9c4
> Author: David Brown <dmlb2000 AT gmail.com>
> Commit: David Brown <dmlb2000 AT gmail.com>
>
>     linux updated maintenance patches
>
> diff --git a/kernels/linux/HISTORY b/kernels/linux/HISTORY
> index 4310f34..5c5bfba 100644
> --- a/kernels/linux/HISTORY
> +++ b/kernels/linux/HISTORY
> @@ -1,4 +1,8 @@
>  2007-05-24 David Brown <dmlb2000 AT gmail.com>
> +       * latest.defaults: updated latest to patch-2.6.21.2
> +       * info/patches/maintenance_patches/patch-2.6.21.2: added
> +
> +2007-05-24 David Brown <dmlb2000 AT gmail.com>
>         * latest.defaults: updated latest to patch-2.6.21-rt7
>         * info/patches/realtime_patches/patch-2.6.21-rt7: added
>         * info/patches/realtime_patches/patch-2.6.21-rt6: removed lost to time
> diff --git a/kernels/linux/info/patches/maintenance_patches/patch-2.6.21.2 
> b/kernels/linux/info/patches/maintenance_patches/patch-2.6.21.2
> new file mode 100755
> index 0000000..91096ab
> --- /dev/null
> +++ b/kernels/linux/info/patches/maintenance_patches/patch-2.6.21.2
> @@ -0,0 +1,6 @@
> +appliedkernels="2.6.21"
> +patchversion="${appliedkernels}.2"
> +source="patch-${patchversion}.bz2"
> +source_url="${KERNEL_URL}/pub/linux/kernel/v2.6/${source}"
> +source_gpg="kernel.gpg:${source}.sign:ESTABLISHED_UPSTREAM_KEY"
> +gpg_source_url="${source_url}.sign"
> diff --git a/kernels/linux/latest.defaults b/kernels/linux/latest.defaults
> index 3c8bc4b..2273e59 100644
> --- a/kernels/linux/latest.defaults
> +++ b/kernels/linux/latest.defaults
> @@ -1,6 +1,6 @@
>  LATEST_2_6=2.6.21
>  LATEST_PRE_2_6=patch-2.6.22-rc2
> -LATEST_maintenance_patches=patch-2.6.21.1
> +LATEST_maintenance_patches=patch-2.6.21.2
>  LATEST_git_patches=patch-2.6.12-rc5-git8
>  LATEST_2_4=2.4.32
>  LATEST_PRE_2_4=patch-2.4.33-pre1

So the History diff is a little misleading really the first line was
added not the 5th. This was caused by having two commits in a single
day.  A lot of times spells will be updated several times during the
day and in the past it was policy (not sure policy or just convention)
that all those changes were lumped together in one History entry.
However, with stable and stable-rc it is advantageous to split up the
commits done in one day so that part of the work can be pushed to
stable and stable-rc and the rest can stay in test (maintenance
patches for the kernel are just one case).

Also adding the offset to GMT gives us a relative time difference so
that History entries don't appear to be out of order when it was just
really a GMT offset issue. For example, ruskie fixes a spell early in
the morning and I notice an issue that he forgot about cause he didn't
get his breakfast yet and wasn't thinking clearly and I fix the
package late at night but then the dates are out of order.

So I'd like to add the time down to the second so that we can do more
than one commit in a day and have the history diff be more accurate to
what got added. Also adding the offset from GMT so that we don't get
our History entries to appear out of order.

As for changing the current history files I'd suggest just zeros
across the board. 2004-05-25 00:00:00-00:00 <foo AT bar.org>

Any thoughts are welcome.

Thanks,
- David Brown