Public SourceMage Discussion List

[David Kowis <dkowis AT shlrm.org>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Wonderful work Karsten!
We're coming real close to having a new, vastly improved installer. The more 
people that read code, the less code that each individual
person has to read. And the more mistakes are likely to be found before we 
ship this out to our new users.
This is the first thing a new user's going to see when Source Mage gets 
installed. It needs to be as good as it can possibly be.

Please let Karsten know if you'd like to review some code. It matters not if 
you have perforce access, he can email you a segment of code
for you to review.

Thanks,
David Kowis

ISO Team Lead - www.sourcemage.org
SourceMage GNU/Linux

Karsten Behrmann wrote:
> Hi all, especially QA team!
> The good news is that the rewrite of the ISO installer is basically 
> complete.
> All that needs to be done (theoretically) is to integrate it into some
> ISO generation scripts and start cranking out ISOs.
> The bad side is that it is largely untested/unrun, and may contain some
> basic errors / brain bugs / stupid syntax problems
> (such as VARIABLE="VALUE" vs. VARIABLE = "VALUE")
> 
> So I'd like to call for volunteers to read through the code and report
> everything they see where
>  - Intended behavior does not seem to be achieved by the code
>  - Intended behavior is unclear
>  - Whatever other suggestions you have
> 
> We're talking about the proj4 tree of cauldron:
> //sgl/cauldron/proj/proj4/...
> 
> I'm sorry that we're a bit scarce on the docs currently.
> What we have (specific to the code) is:
> http://wiki.sourcemage.org/index.php?page=ISO+installer+design+specs
> (in the p4 tree)
>   doc/installer/globals.list (list of global variables used)
>   doc/installer/depends.list (list of "depends" employed)
> The code
> (to quote the programmer guide:
> "The source code can at worst be wrong and confusing. The documentation, if
> not written perfectly, can lie, and that is a thousand times worse.")
> I have been a tad pressed for time, so sorry that there is not as much
> documentation yet as there should be.
> 
> Basically, the parts I'd like to see reviewed are
>   installer/installer.sh
>   installer/modules/*
> best to read first:
>   installer/modules/common
> and
>   installer/modules/spellinstaller
> They're used quite a bit in the other parts of the code.
> 
> An example I just found of what I'm looking for for example:
>   installer/modules/common :
> -  ${DIALOG[*]} $*
> +  "${DIALOG[@]}" "$@"
> (word splitting makes the two different)
> 
> I guess that's it for now.
> So Far,
>   Karsten
> 
> 
> ------------------------------------------------------------------------
> 
> _______________________________________________
> SM-Discuss mailing list
> SM-Discuss AT lists.ibiblio.org
> http://lists.ibiblio.org/mailman/listinfo/sm-discuss
> 
> 
> !DSPAM:42d05bf0129771440020579!

- --

One login to rule them all, one login to find them. One login to bring them 
all, and in the web bind them.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (MingW32)

iD4DBQFC0Fv/tgErhgxHMHsRAt9zAJYtEftWbxZWN/IN4+o6rONUXKEaAJ9/SfF8
Zqbk4pMmQWbFoptH0ZP06A==
=NSx3
-----END PGP SIGNATURE-----