Skip to Content.
Sympa Menu

sm-discuss - [SM-Discuss] excluded/protected files

sm-discuss AT lists.ibiblio.org

Subject: Public SourceMage Discussion List

List archive

Chronological Thread  
  • From: Andrew <afrayedknot AT thefrayedknot.armory.com>
  • To: sm-discuss AT lists.ibiblio.org
  • Subject: [SM-Discuss] excluded/protected files
  • Date: Mon, 18 Oct 2004 22:11:33 -0700

Hi, I'd like to make a change to the /var/lib/sorcery/excluded and
protected files. Right now they are the names of files and directories to
ignore in certain parts of the file tracking and dispelling process. The
limitation of these files is that wildcards are not allowed (even through
excluded lists one, it doesn't work)

Id like to change the files to contain regexps, one per line, that will
be |'ed together inside the filter function. Its then up to the author
whether or not to put a $ at the end (or not) which indicates if the
entry is a file (or a directory). The pattern can of course contain
.*'s and all that other regexp goodness.

The advantage to this is that we can relatively efficiently solve
bug 6423, which has been outstanding for a while. The submitted
patch unfortunatly only allows glob patterns, which in-turn can require
significant (and in many cases unacceptable) filesystem overhead. This
also makes the filter function simpler and usually faster because it
avoids (possibly slow) filesystem lookups of the current implementation.
Timing the two versions side by side yields the new version slightly faster.

The only non-developer impact with this is that there is a LOCAL_EXCLUDED
file that allows users to exclude things on their own. Im not sure how
widely used it is since its never been actively advertised. Also the
only consequence is that more stuff will be excluded than usual
since the regexps wont be anchored by ^ and $. That means silly short
patterns like /media will match in other places, but I dont expect
anyone not reading this email to be using that file or using really
silly short patterns.

This change will of course go into devel for a good long while, I want
to do this early in the game to make sure its well tested.

Comments/questions/ideas?

-Andrew





Archive powered by MHonArc 2.6.24.

Top of Page