Skip to Content.
Sympa Menu

sm-commit - Re: [SM-Commit] GIT changes to master grimoire by Bor Kraljič (d7a8fe66abf6bd38d69d19707580fcbf6d849e45)

sm-commit AT lists.ibiblio.org

Subject: Source Mage code commit list

List archive

Chronological Thread  
  • From: Eric Sandall <eric AT sandall.us>
  • To: sm-commit AT lists.ibiblio.org
  • Subject: Re: [SM-Commit] GIT changes to master grimoire by Bor Kraljič (d7a8fe66abf6bd38d69d19707580fcbf6d849e45)
  • Date: Wed, 30 Sep 2009 16:52:26 -0700

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Bor Kraljic wrote:
> Dne ponedeljek 28 septembra 2009 ob 20:25:58 je Eric Sandall napisal(a):
>> Jaka Kranjc wrote:
>>> On Monday 28 of September 2009 11:30:21 Bor Kraljič wrote:
>>>> --- /dev/null
>>>> +++ b/audio-libs/liblastfm/BUILD
>>>> @@ -0,0 +1,4 @@
>>>> +QTDIR=/usr &&
>>>> +PATH=$QTDIR/bin/qt4:$PATH &&
>>>> +./configure --prefix /usr &&
>>>> +default_build_make
>>> Is the configure special - why don't you just use default_build?
>>> Hardcoding
>>> QTDIR is bad, we have a profile script for that. Also check FUNCTIONS.
>> You should source /etc/profile.d/kde4.sh to get the KDE4 variables, not
>> hardcode them.
> There are at least 3 things why this is not a good idea.
> 1) /etc/profile.d/kde4.sh does NOT have $QTDIR variable
> 2) /etc/profile.d/kde4.sh has a "if [ "$USER" != "root" ];then" on the
> beginning. So because we are running sorcery as root it wouldn't read any
> of variable. (Please correct me if i am wrong for this one)
> 3) /etc/profile.d/kde4.sh comes from spell kdebase-workspace4. That means
> it would need to on the computer before install of this spell. That would
> be non-optional dependency... and that is in my opinion completely
> unnecessary dependency.
>
> I fixed the vars in commit 27bf145dbe6cca2e40d286d0f2260df4dc7226bf. If you
> have have any suggestion to the new "version" please let me know. But I
> really think that source /etc/profile.d/kde4.sh is the way to go.
>
> have a nice day

I was pretty sure kde4.sh setup the QT4 variables, since qt.sh does not.
Regardless, you are correct in that it wouldn't work for Sorcery anyways. :)

I apparently was thinking of $GRIMOIRE/kde4/FUNCTIONS and that it
overrides default_build for QT4 apps. $GRIMOIRE/FUNCTIONS also has a
qt4_cmake_build and qt4_build to take care of this for you, we should
use these instead.

- -sandalle
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (MingW32)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAkrD7zoACgkQtYuTaRcbbyanIgCfU3SsXigdgXWfHYeZtvrTjFU+
X5kAn0UQXxy9MVWSgKffkZAsOw2un+Q/
=gImL
-----END PGP SIGNATURE-----





Archive powered by MHonArc 2.6.24.

Top of Page