Skip to Content.
Sympa Menu

sm-commit - Re: [SM-Commit] GIT changes to master grimoire by Bor Kraljič (d7a8fe66abf6bd38d69d19707580fcbf6d849e45)

sm-commit AT lists.ibiblio.org

Subject: Source Mage code commit list

List archive

Chronological Thread  
  • From: Eric Sandall <eric AT sandall.us>
  • To: sm-commit AT lists.ibiblio.org
  • Subject: Re: [SM-Commit] GIT changes to master grimoire by Bor Kraljič (d7a8fe66abf6bd38d69d19707580fcbf6d849e45)
  • Date: Mon, 28 Sep 2009 11:25:58 -0700

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Jaka Kranjc wrote:
> On Monday 28 of September 2009 11:30:21 Bor Kraljič wrote:
>> --- /dev/null
>> +++ b/audio-libs/liblastfm/BUILD
>> @@ -0,0 +1,4 @@
>> +QTDIR=/usr &&
>> +PATH=$QTDIR/bin/qt4:$PATH &&
>> +./configure --prefix /usr &&
>> +default_build_make
> Is the configure special - why don't you just use default_build? Hardcoding
> QTDIR is bad, we have a profile script for that. Also check FUNCTIONS.

You should source /etc/profile.d/kde4.sh to get the KDE4 variables, not
hardcode them.

- -sandalle

- --
Eric Sandall | Source Mage GNU/Linux Developer
eric AT sandall.us PGP: 0xA8EFDD61 | http://www.sourcemage.org/
http://eric.sandall.us/ | http://counter.li.org/ #196285
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAkrA/7YACgkQHXt9dKjv3WHUwgCdHw6JPSGiAwsRhwFsivfHBxgi
eKEAn0HVyxhPXD5BPtO/FKMU/6YGgbp7
=MAgw
-----END PGP SIGNATURE-----




Archive powered by MHonArc 2.6.24.

Top of Page