Skip to Content.
Sympa Menu

sm-commit - Re: [SM-Commit] GIT changes to master grimoire by Bor Kraljič (d7a8fe66abf6bd38d69d19707580fcbf6d849e45)

sm-commit AT lists.ibiblio.org

Subject: Source Mage code commit list

List archive

Chronological Thread  
  • From: Bor Kraljic <pyrobor AT ver.si>
  • To: sm-commit AT lists.ibiblio.org
  • Subject: Re: [SM-Commit] GIT changes to master grimoire by Bor Kraljič (d7a8fe66abf6bd38d69d19707580fcbf6d849e45)
  • Date: Mon, 28 Sep 2009 12:16:18 +0200

Dne ponedeljek 28 septembra 2009 ob 11:46:10 je Jaka Kranjc napisal(a):
> On Monday 28 of September 2009 11:30:21 Bor Kraljič wrote:
> > --- /dev/null
> > +++ b/audio-libs/liblastfm/BUILD
> > @@ -0,0 +1,4 @@
> > +QTDIR=/usr &&
> > +PATH=$QTDIR/bin/qt4:$PATH &&
> > +./configure --prefix /usr &&
> > +default_build_make
> Is the configure special - why don't you just use default_build? Hardcoding
> QTDIR is bad, we have a profile script for that. Also check FUNCTIONS.
>
> LP

Yes the configure is special... it needs to have space between the --prefix
and "$INSTALL_ROOT/usr" and not "=" as it is specify in default_build. Also
is there anything to add to the configure? (usage: ./configure [--prefix
<dir>] [--no-strip] [--release]) Will be these modifications for QTDIR ok?

--- a/audio-libs/liblastfm/BUILD
+++ b/audio-libs/liblastfm/BUILD
@@ -1,4 +1,4 @@
-QTDIR=/usr &&
-PATH=$QTDIR/bin/qt4:$PATH &&
-./configure --prefix /usr &&
-default_build_make
+QTDIR="${QTDIR:-$INSTALL_ROOT/usr}" &&
+PATH="$QTDIR/bin/qt4:$PATH" &&
+./configure --prefix $INSTALL_ROOT/usr &&
+make

I also used the used make instead of default_build_make since that functions
only does is make...

Attachment: signature.asc
Description: This is a digitally signed message part.




Archive powered by MHonArc 2.6.24.

Top of Page