Source Mage code commit list

[Andrew <afrayedknot AT thefrayedknot.armory.com>]

On Thu, Aug 03, 2006 at 11:56:34AM +0200, Flavien Bridault wrote:
> Le jeudi 03 août 2006 à 00:37 -0700, Andrew a écrit :
> > On Thu, Aug 03, 2006 at 01:25:39AM +0200, Ladislav Hagara wrote:
> > > >
> > > >> Not a big deal, but I have understood we should reset PATCHLEVEL when
> > > >> upgrading...
> > > > Correct. According to http://wiki.sourcemage.org/DETAILS, PATCHLEVEL
> > > > should be removed when VERSION is changed.
> > > 
> > > My English is horrible but "should be" surely does not mean "must be".
> > 
> > Its "should be" in the context of, the software won't break if you
> > don't. "Must be" would imply that something would not function properly
> > otherwise. For example, a valid SOURCE_URL must be specified in order
> > for downloading to work.
> > 
> > As I recall, the reason to reset PATCHLEVEL was so it was obvious to a
> > user how many times a particular version has been patched. That was at
> > the time the agreed upon and widely discussed purpose of that variable.
> > 
> > 
> > > I don't think developers reset it.
> > Most of these updates are so absurdly trivial I dont know why they're
> > still done "by hand". A script could do this for you then you.
> > 
> > sed -i '/PATCHLEVEL=/D' DETAILS
> > 
> 
> The annoying part is the multi-versions spell. The PATCHLEVEL applies to
> all versions so if you update only one of these, you can't reset it.
> Unless to provide a PATCHLEVEL for each version within the if
> condition ? Ex: 
> 
> if [ "$DEVEL" = "y" ]; then 
>   VERSION=2.3.23
>   PATCHLEVEL=2
> else
>   VERSION=2.2.34
>   PATCHLEVEL=2
> fi
> 
> That way you can reset safely, right ? I never noticed such a syntax
> anywhere though... Just my two cents, unless this might be obvious for
> some people (that was not for me until now ;-) ).

You'd probably want to do it that way.
Thats how the glibc spell does it.


-Andrew