Skip to Content.
Sympa Menu

sm-commit - Re: [SM-Commit] GIT changes to master grimoire by Ladislav Hagara (c4f7997820fb7e9b2976a23ef34203ae35cf2775)

sm-commit AT lists.ibiblio.org

Subject: Source Mage code commit list

List archive

Chronological Thread  
  • From: Andrew <afrayedknot AT thefrayedknot.armory.com>
  • To: SM-Commit <sm-commit AT lists.ibiblio.org>
  • Subject: Re: [SM-Commit] GIT changes to master grimoire by Ladislav Hagara (c4f7997820fb7e9b2976a23ef34203ae35cf2775)
  • Date: Thu, 3 Aug 2006 00:37:28 -0700

On Thu, Aug 03, 2006 at 01:25:39AM +0200, Ladislav Hagara wrote:
> >
> >> Not a big deal, but I have understood we should reset PATCHLEVEL when
> >> upgrading...
> > Correct. According to http://wiki.sourcemage.org/DETAILS, PATCHLEVEL
> > should be removed when VERSION is changed.
>
> My English is horrible but "should be" surely does not mean "must be".

Its "should be" in the context of, the software won't break if you
don't. "Must be" would imply that something would not function properly
otherwise. For example, a valid SOURCE_URL must be specified in order
for downloading to work.

As I recall, the reason to reset PATCHLEVEL was so it was obvious to a
user how many times a particular version has been patched. That was at
the time the agreed upon and widely discussed purpose of that variable.


> I don't think developers reset it.
Most of these updates are so absurdly trivial I dont know why they're
still done "by hand". A script could do this for you then you.

sed -i '/PATCHLEVEL=/D' DETAILS

> Of course it isn't a problem.
> Just looking into "udev" spell. Who updated it to new version (even last
> two updates) and didn't reset PATCHLEVEL? :-)

"Two wrongs dont make a right."

-Andrew





Archive powered by MHonArc 2.6.24.

Top of Page