Skip to Content.
Sympa Menu

sm-commit - Re: [SM-Commit] GIT changes to master grimoire by Ladislav Hagara (c4f7997820fb7e9b2976a23ef34203ae35cf2775)

sm-commit AT lists.ibiblio.org

Subject: Source Mage code commit list

List archive

Chronological Thread  
  • From: Flavien Bridault <vlaaad AT sourcemage.org>
  • To: sm-commit AT lists.ibiblio.org
  • Subject: Re: [SM-Commit] GIT changes to master grimoire by Ladislav Hagara (c4f7997820fb7e9b2976a23ef34203ae35cf2775)
  • Date: Thu, 03 Aug 2006 11:56:34 +0200

Le jeudi 03 août 2006 à 00:37 -0700, Andrew a écrit :
> On Thu, Aug 03, 2006 at 01:25:39AM +0200, Ladislav Hagara wrote:
> > >
> > >> Not a big deal, but I have understood we should reset PATCHLEVEL when
> > >> upgrading...
> > > Correct. According to http://wiki.sourcemage.org/DETAILS, PATCHLEVEL
> > > should be removed when VERSION is changed.
> >
> > My English is horrible but "should be" surely does not mean "must be".
>
> Its "should be" in the context of, the software won't break if you
> don't. "Must be" would imply that something would not function properly
> otherwise. For example, a valid SOURCE_URL must be specified in order
> for downloading to work.
>
> As I recall, the reason to reset PATCHLEVEL was so it was obvious to a
> user how many times a particular version has been patched. That was at
> the time the agreed upon and widely discussed purpose of that variable.
>
>
> > I don't think developers reset it.
> Most of these updates are so absurdly trivial I dont know why they're
> still done "by hand". A script could do this for you then you.
>
> sed -i '/PATCHLEVEL=/D' DETAILS
>

The annoying part is the multi-versions spell. The PATCHLEVEL applies to
all versions so if you update only one of these, you can't reset it.
Unless to provide a PATCHLEVEL for each version within the if
condition ? Ex:

if [ "$DEVEL" = "y" ]; then
VERSION=2.3.23
PATCHLEVEL=2
else
VERSION=2.2.34
PATCHLEVEL=2
fi

That way you can reset safely, right ? I never noticed such a syntax
anywhere though... Just my two cents, unless this might be obvious for
some people (that was not for me until now ;-) ).

> > Of course it isn't a problem.
> > Just looking into "udev" spell. Who updated it to new version (even last
> > two updates) and didn't reset PATCHLEVEL? :-)
>
> "Two wrongs dont make a right."
>
> -Andrew
>
> _______________________________________________
> SM-Commit mailing list
> SM-Commit AT lists.ibiblio.org
> http://lists.ibiblio.org/mailman/listinfo/sm-commit
>
--
Flavien Bridault

Disk, Graphics, Graphics-libs sections Guru
Source Mage GNU/Linux - http://www.sourcemage.org

irc: vlaaad
jabber: vlaaad AT amessage.be

Attachment: signature.asc
Description: Ceci est une partie de message numériquement signée




Archive powered by MHonArc 2.6.24.

Top of Page