Skip to Content.
Sympa Menu

sm-commit - Re: [SM-Commit] PERFORCE change 78956 by Robin Cook for review

sm-commit AT lists.ibiblio.org

Subject: Source Mage code commit list

List archive

Chronological Thread  
  • From: seth AT swoolley.homeip.net
  • To: SM-Commit Daemon <sm-commit AT lists.ibiblio.org>
  • Subject: Re: [SM-Commit] PERFORCE change 78956 by Robin Cook for review
  • Date: Sun, 7 May 2006 10:20:44 -0700

On Sun, May 07, 2006 at 07:09:53PM +0200, Arwed von Merkatz wrote:
> On Sun, May 07, 2006 at 09:54:59AM -0700, seth AT swoolley.homeip.net wrote:
> > On Sun, May 07, 2006 at 10:40:26AM +0200, Andra?? ruskie Levstik wrote:
> > > Perforce Review Daemon wrote :
> > >
> > > > ==== //sgl/grimoires/test/x11-toolkits/xaw3d/BUILD#2 (xtext) ====
> > > >
> > > > @@ -9,4 +9,9 @@
> > > > sedit 's/#define wcsncpy.*$//' XawI18n.h &&
> > > > xmkmf &&
> > > > make Makefiles &&
> > > > +
> > > > +if spell_ok xorg-server; then
> > > > + sedit "s:/X11R6::g" Makefile
> > > > +fi &&
> > > > +
> > > > make
> > > >
> > >
> > > IMHO this would be better if it would be done like this:
> > > if test "$(get_spell_provider $SPELL X11-LIBS)" = xorg-server; then
> > > sedit "s:/X11R6::g" Makefile
> > > fi &&
> >
> > Technically one should check to see what they selected for the X11-LIBS
> > provider for this spell, but I don't know an api-correct way to do that.
>
> That's exactly what $(get_spell_provider $SPELL X11-LIBS) does.

Ahh, dumb me, I didn't realize it referred to $SPELL in the args. :)




Archive powered by MHonArc 2.6.24.

Top of Page