Skip to Content.
Sympa Menu

sm-commit - Re: [SM-Commit] PERFORCE change 78956 by Robin Cook for review

sm-commit AT lists.ibiblio.org

Subject: Source Mage code commit list

List archive

Chronological Thread  
  • From: seth AT swoolley.homeip.net
  • To: Andra AT swoolley.homeip.net
  • Cc: duane_malcolm <d.malcolm AT auckland.ac.nz>, Unet <unet AT sourcemage.org>, Gareth Clay <gareth AT caffeinefuelled.co.uk>, Andrew Stitt <a AT thefrayedknot.armory.com>, SM-Commit Daemon <sm-commit AT lists.ibiblio.org>, Arjan Bouter <abouter AT sourcemage.org>, vladimir_marek <vlmarek AT volny.cz>, Maurizio Boriani <baux AT member.fsf.org>, Ethan Grammatikidis <eekee AT eekee.is-a-geek.org>
  • Subject: Re: [SM-Commit] PERFORCE change 78956 by Robin Cook for review
  • Date: Sun, 7 May 2006 09:54:59 -0700

On Sun, May 07, 2006 at 10:40:26AM +0200, Andra?? ruskie Levstik wrote:
> Perforce Review Daemon wrote :
>
> > ==== //sgl/grimoires/test/x11-toolkits/xaw3d/BUILD#2 (xtext) ====
> >
> > @@ -9,4 +9,9 @@
> > sedit 's/#define wcsncpy.*$//' XawI18n.h &&
> > xmkmf &&
> > make Makefiles &&
> > +
> > +if spell_ok xorg-server; then
> > + sedit "s:/X11R6::g" Makefile
> > +fi &&
> > +
> > make
> >
>
> IMHO this would be better if it would be done like this:
> if test "$(get_spell_provider $SPELL X11-LIBS)" = xorg-server; then
> sedit "s:/X11R6::g" Makefile
> fi &&

Technically one should check to see what they selected for the X11-LIBS
provider for this spell, but I don't know an api-correct way to do that.
Grepping the depends file should work though.

Seth




Archive powered by MHonArc 2.6.24.

Top of Page