sm-commit AT lists.ibiblio.org

Subject: Source Mage code commit list

List archive

Re: [SM-Commit] PERFORCE change 78956 by Robin Cook for review

From: "Andraž \"ruskie\" Levstik" <ruskie AT mages.ath.cx>
To: Robin Cook <rcook AT wyrms.net>
Cc: duane_malcolm <d.malcolm AT auckland.ac.nz>, Unet <unet AT sourcemage.org>, SM-Commit Daemon <sm-commit AT lists.ibiblio.org>, Andrew Stitt <a AT t.armory.com>, Arjan Bouter <abouter AT sourcemage.org>, vladimir_marek <vlmarek AT volny.cz>, Maurizio Boriani <baux AT member.fsf.org>, Ethan Grammatikidis <eekee AT eekee.is-a-geek.org>, Gareth Clay <gareth AT caffeinefuelled.co.uk>
Subject: Re: [SM-Commit] PERFORCE change 78956 by Robin Cook for review
Date: Sun, 7 May 2006 10:40:26 +0200

Perforce Review Daemon wrote :

> ==== //sgl/grimoires/test/x11-toolkits/xaw3d/BUILD#2 (xtext) ====
>
> @@ -9,4 +9,9 @@
> sedit 's/#define wcsncpy.*$//' XawI18n.h &&
> xmkmf &&
> make Makefiles &&
> +
> +if spell_ok xorg-server; then
> + sedit "s:/X11R6::g" Makefile
> +fi &&
> +
> make
>

IMHO this would be better if it would be done like this:
if test "$(get_spell_provider $SPELL X11-LIBS)" = xorg-server; then
sedit "s:/X11R6::g" Makefile
fi &&

--
Andraž "ruskie" Levstik
Source Mage GNU/Linux Games grimoire guru
Geek/Hacker/Tinker

Hacker FAQ: http://www.plethora.net/%7eseebs/faqs/hacker.html

Key id = A7A9E461
Key fingerprint = 757E C16B F5B7 DC27 B003 CCED CF95 3A77 A7A9 E461

[SM-Commit] PERFORCE change 78956 by Robin Cook for review, Perforce Review Daemon, 05/06/2006
- Re: [SM-Commit] PERFORCE change 78956 by Robin Cook for review, Andraž "ruskie" Levstik, 05/07/2006
  - Re: [SM-Commit] PERFORCE change 78956 by Robin Cook for review, seth, 05/07/2006
    - Re: [SM-Commit] PERFORCE change 78956 by Robin Cook for review, Arwed von Merkatz, 05/07/2006
      - Re: [SM-Commit] PERFORCE change 78956 by Robin Cook for review, seth, 05/07/2006
    - Re: [SM-Commit] PERFORCE change 78956 by Robin Cook for review, Andrew, 05/07/2006