FreeTDS Development Group

[Frediano Ziglio <freddy77 AT gmail.com>]

2009/10/30 Frediano Ziglio <freddy77 AT gmail.com>:
> 2009/10/30 James K. Lowden <jklowden AT freetds.org>:
>> Frediano Ziglio wrote:
>>> 0.62 understand only "server:port" syntax so
>>> it finds "myserver\one" correctly. 0.82 change "myserver\one" to
>>> "myserver" with instance "one" so it doesn't find "myserver" section
>>> in file. The solution would be to search for server before parsing for
>>> instance. This way does not break compatibility.
>>
>> Good idea!
>>
>
> Yes, but I don't like that much my patch... I think that
> server\instance and server:port should be symmetric...
>
> 0.62
>
> "server\instance" -> look for section "server\instance"
> "server:port" -> look for section server with port set to "port"
>
> 0.82
>
> "server\instance" -> look for section "server" with instance set to 
> "instance"
> "server:port" -> look for section "server" with port set to "port"
>
> my proposed patch
>
> "server\instance" -> look for section "server\instance", if not found
> look for section "server" with instance set to "instance"
> "server:port" -> look for section "server" with port set to "port"
>
> as you can note is not symmetric... I proposed this way
>
> "server\instance" -> look for section "server\instance", if not found
> look for section "server" with instance set to "instance"
> "server:port" -> look for section "server:port", if not found look for
> section "server" with port set to "port"
>

This patch should work (and is smaller too!)

freddy77

Attachment: instance_fix.diff
Description: Binary data