FreeTDS Development Group

["ZIGLIO, Frediano, VF-IT" <Frediano.Ziglio AT vodafone.com>]

> 
> Hi Iain,
> 
> Your diagnosis is correct. 
> This functionality did regress somewhere between 0.62 and 0.63, 
> as a result of improvements to the "query with ? 
> placeholders" logic for
> both ODBC and ct-library (ct_dynamic)
> 
> I have fixed and improved this now. 
> A patch will be on its way to freetds this week.
> 
> Bill
> 

Patch accepted and committed however I'd discuss some part.

tds_build_param_def_from_query and tds_build_param_def_from_params are
too similar, is better to reuse code. 

tds_submit_query_params was used only by ctlib so there is no reason for
a tds_submit_query_params_ct, also IMO tds_submit_query_params_ct should
support named and no named parameters (even using TDS7). I removed code
to test for tds version (lang_ct_param.c and ct.c).

I removed a test for TDS_SP_EXECUTE (token.c) that would change result
from TDS_DONEPROC_RESULT to TDS_DONE_RESULT, it break an odbc test
(removing that change do not break any ctlib test).

I also added a test for lang_ct_param to test real insertion of row, see
output using mssql at
http://freetds.sourceforge.net/out/test/test27.html.

freddy77