FreeTDS Development Group

["Frediano Ziglio" <freddyz77 AT lycos.com>]

>I *think* I incorporated our discussion in code.  Freddy, I used ideas
>from your patch, but of course I couldn't apply it.  
>

The code works, good!
There are only some more iconv issues to fix :)

- finish support for no-GNU iconv (indirect conversion see src/tds/iconv.c)

one of my TODO

- borrow GNU's libiconv m4 macro to test/provide EILSEQ
  (some iconv implementation do not return EILSEQ, some platforms do not 
define EILSEQ)

We need this ?

- add test for locale_charset() to configure.in.  Use it if available instead 
of nl_langinfo, because it implies we're using GNU iconv

We never used nl_langinfo...

>I committed the ct-lib univarchar patch separately.  On faith. No way for
>me to test.  
>

The same. I don't like some thing in implementation
- Sybase do not have CS_UNIVARCHAR_TYPE constant but only CS_UNICHAR_TYPE
- SYBUNIVARCHAR it's not a server type
- there are no conversion from UTF16 to client

>The tds UTF-8 unit tests now pass.  
>
>There's just one problem: I've been confusing EILSEQ and EINVAL:
>
>  1.  An invalid multibyte sequence is encountered in the
>  input. In this case it sets errno to EILSEQ....
>       ...
>  3.  An incomplete multibyte sequence is encountered in the
>  input, and the input byte sequence terminates after it. In
>  this case it sets errno to EINVAL....
>
>I had them reversed in my head.  I've swapped them now, I think.  But I
>have to go over the code again to undo my confusion.  
>
>Our "chunking" discussion regards EINVAL: an incomplete character at the
>end of the buffer due to giving tds_iconv() an arbitrary chunk to work on
>(i.e., one not necessarily respecting character boundaries).  
>
>A bit of s/EILSEQ/EINVAL/g should help.  
>

Fixed. Now even utf8_2 test works

freddy77



____________________________________________________________
Get advanced SPAM filtering on Webmail or POP Mail ... Get Lycos Mail!
http://login.mail.lycos.com/r/referral?aid=27005