FreeTDS Development Group

["Castellano, Nicholas" <Nicholas_Castellano AT acml.com>]

OK, I committed my fix for out-of-range column numbers in revision 1.21 of
bcp.c.  I verified that a bcp out with out-of-range column numbers now
behaves the same as Sybase's bcp utility, instead of dumping core or
producing incorrect data.

Please verify that this change solves the problem you observed.

Cheers,
--nick

-----Original Message-----
From: bounce-freetds-145195 AT franklin.oit.unc.edu
[mailto:bounce-freetds-145195 AT franklin.oit.unc.edu] 
Sent: Thursday, September 26, 2002 12:31 PM
To: TDS Development Group
Subject: [freetds] RE: buglets in the bcp code


On Wed, Sep 25, 2002 at 12:11:02PM -0400, Castellano, Nicholas wrote:
> The first loop is iterating over the columns from the server, while 
> the second loop is iterating over the columns in the host file.

> I think what's needed is a check like this in the second loop, after 
> hostcol is assigned:

> if ((hostcol->tab_colnum < 1) || (hostcol->tab_colnum >
> dbproc->bcp_colcount)) {
>       continue;
> }

I'll take your word for it and gladly defer to your greater insight in
getting this fixed in CVS. :)

Steve Langasek
postmodern programmer


The information contained in this transmission may contain privileged and
confidential information and is intended only for the use of the person(s)
named above.  If you are not the intended recipient, or an employee or agent
responsible for delivering this message to the intended recipient, any
review, dissemination, distribution or duplication of this communication is
strictly prohibited. If you are not the intended recipient, please contact
the sender immediately by reply e-mail and destroy all copies of the
original message. Please note that for certain accounts we do not accept
orders and/or instructions by e-mail, and for those accounts we will not be
responsible for carrying out such orders and/or instructions. Kindly refrain
from sending orders or instructions by e-mail unless you have confirmed that
we accept such communications for your account. Please also note that to
satisfy regulatory requirements we review the outgoing and incoming e-mail
correspondence of staff members serving certain functions.