FreeTDS Development Group

["Castellano, Nicholas" <Nicholas_Castellano AT acml.com>]

This afternoon after lunch and a meeting, I will be committing a fairly
large change that affects a lot of modules.

- Implements tds_close_socket() as requested by Brian.
- Uses same throughout the codebase, wherever a socket is closed.
- Uses -1 instead of 0 as the file descriptor to indicate a closed socket.
  0 is a perfectly valid fd, so using it to indicate a closed socket is bad.
- Uses a new macro IS_TDSDEAD(tds) throughout the codebase to check for
closed sockets,
  instead of adhoc expressions like "if (tds && tds->s) { ... }"

I'm pretty sure I nailed all instances where the socket was compared against
0.  If I missed any, feel free to hurl insults and invective my way when
your programs crash horribly :-)

--nick


The information contained in this transmission may contain privileged and
confidential information and is intended only for the use of the person(s)
named above.  If you are not the intended recipient, or an employee or agent
responsible for delivering this message to the intended recipient, any
review, dissemination, distribution or duplication of this communication is
strictly prohibited. If you are not the intended recipient, please contact
the sender immediately by reply e-mail and destroy all copies of the
original message. Please note that for certain accounts we do not accept
orders and/or instructions by e-mail, and for those accounts we will not be
responsible for carrying out such orders and/or instructions. Kindly refrain
from sending orders or instructions by e-mail unless you have confirmed that
we accept such communications for your account. Please also note that to
satisfy regulatory requirements we review the outgoing and incoming e-mail
correspondence of staff members serving certain functions.