Skip to Content.
Sympa Menu

xom-interest - Re: [XOM-interest] XOM 1.1d1: setInternalDTDSubset

xom-interest AT lists.ibiblio.org

Subject: XOM API for Processing XML with Java

List archive

Chronological Thread  
  • From: Wolfgang Hoschek <whoschek AT lbl.gov>
  • To: Elliotte Harold <elharo AT metalab.unc.edu>
  • Cc: xom-interest <xom-interest AT lists.ibiblio.org>
  • Subject: Re: [XOM-interest] XOM 1.1d1: setInternalDTDSubset
  • Date: Sat, 8 Jan 2005 10:35:14 -0800

On Jan 8, 2005, at 10:21 AM, Elliotte Harold wrote:

Wolfgang Hoschek wrote:

Plus you could move the "empty" static variable inside the method for improved clarity:
// private static InputSource empty;
static synchronized void checkInternalDTDSubset(String subset) {
if (parser == null) {
//empty = new InputSource(new EmptyReader());
final InputSource empty = new InputSource(new EmptyReader());
... and so on

Yes. It just didn't seem necessary to recreate that object on every pass through the method, though I'm sure it's not as heavyweight an operation as loading a parser.

It's still only created once, that is initially on parser == null.





Archive powered by MHonArc 2.6.24.

Top of Page