Skip to Content.
Sympa Menu

sm-sorcery - Re: [SM-Sorcery] splitting BUILD

sm-sorcery AT lists.ibiblio.org

Subject: Discussion of Sorcery related topics

List archive

Chronological Thread  
  • From: Arwed von Merkatz <v.merkatz AT gmx.net>
  • To: sm-sorcery AT lists.ibiblio.org
  • Subject: Re: [SM-Sorcery] splitting BUILD
  • Date: Sat, 13 Mar 2004 11:57:43 +0100

On Sat, Mar 13, 2004 at 06:35:33PM +1100, Hamish Greig wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> On Sat, 13 Mar 2004 18:20, Andrew wrote:
> > So once again, any ideas on what to do about the awkward naming of
> > POST_BUILD? (as it runs after INSTALL but before POST_INSTALL).
> > maybe INSTALL_EXTRA? But that doesn't imply that it shuts off installwatch
> > et. al. perhaps INSTALL_END?
> >
> > Help me out here. Or tell me that the names are staying even though
> > they're
> > misleading.
> >
> > -Andrew
>
> despite the extra work and immediate overheads of renaming files it would
> be
> logical for POST_BUILD to be renamed POST_INSTALL and for POST_INSTALL to
> be
> renamed FINAL ? The name is just a suggestion but it should unambiguously
> say
> it is the last thing to get run. I always thought POST_INSTALL is
> misleading
> as it actually gets run last thing and has little relation to the actual
> install part of BUILD.

I agree that it should be renamed, the overhead isn't very big (i
renamed the WEBSERVER provides to APACHE some days ago, it's easy to do
such changes with a nice script :)
The names POST_INSTALL and FINAL as described above sound good to me.

Before starting such a big change though, we'd need to have the relevant
code in sorcery very well tested and then put into stable. This should
also be postponed until gnome2 final is done, because devel grimoire
will be a testing ground for the gnome2 beta for the next week.
So, time enough to think this through and test it extensively :)

I got some questions/suggestions about the COMPILE/INSTALL design:
- sorcery should run prepare_install automatically before calling
INSTALL (i'm not sure if you meant that, but i couldn't find it
explicitly mentioned in the wiki page
- "run_compile and run_install should consist of logically split
portions of run_build. An enhancement thereof would be to take the
code that deals with ./configure out of that run_build (as it will have
to be duplicated) and place it in a seperate function."
What do you mean with "as it will have to be duplicated"? Do you plan
to run configure again in INSTALL? I can assure you this will break
with several hundreds of programs, due to the many buggy automake
setups used by software authors.

--
Arwed v. Merkatz Sourcemage GNU/Linux developer
http://www.sourcemage.org




Archive powered by MHonArc 2.6.24.

Top of Page