Bugs for Sorcery are reported here

[bugzilla-daemon AT bugs.sourcemage.org]

http://bugs.sourcemage.org/show_bug.cgi?id=13938





--- Comment #29 from Andraž 'ruskie' Levstik <ruskie+bugs AT codemages.net>  
2010-04-28 00:23:26 ---
(In reply to comment #28)
> Do the spell file exclusion in a new function (run_spellfile_hook?), so it
> doesn't need to be duplicated. You can also achieve nicer calling by making 
> it
> take two arguments: spellfile pre|post. This needs to be as efficient as
> possible, as it will be run a lot.

Hmm run_hook will work then for the exclussions just need to split the call
into two param state. 


> MAIL_REPORT_HOOK does not need to be global and initialised as empty. It's 
> not
> needed at all - you can pass all that info by grouping the commands with {}.

Erm...

> Apart from that, the mail and sound hooks are fine. The cleantext should
> eventually be in a spell, as it definitely won't get included and the
> term_title one should be trimmed down, since about half of the functions are
> redundant.

Yeah just automated it at the moment.

> The calls to init_hooks look fine.
> 
> There's plenty of misformatting; some as a regression.

Hmm I'll look into it though not really sure what to look for but will try and
see.

-- 
Configure bugmail: http://bugs.sourcemage.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.