Skip to Content.
Sympa Menu

sm-sorcery-bugs - [SM-Sorcery-Bugs] [Bug 13938] Hooks support in sorcery...

sm-sorcery-bugs AT lists.ibiblio.org

Subject: Bugs for Sorcery are reported here

List archive

Chronological Thread  
  • From: bugzilla-daemon AT bugs.sourcemage.org
  • To: sm-sorcery-bugs AT lists.ibiblio.org
  • Subject: [SM-Sorcery-Bugs] [Bug 13938] Hooks support in sorcery...
  • Date: 27 Apr 2010 21:35:43 -0000

http://bugs.sourcemage.org/show_bug.cgi?id=13938





--- Comment #28 from Jaka Kranjc <svn AT lynxlynx.info> 2010-04-27 16:35:40 ---
Do the spell file exclusion in a new function (run_spellfile_hook?), so it
doesn't need to be duplicated. You can also achieve nicer calling by making it
take two arguments: spellfile pre|post. This needs to be as efficient as
possible, as it will be run a lot.

MAIL_REPORT_HOOK does not need to be global and initialised as empty. It's not
needed at all - you can pass all that info by grouping the commands with {}.

Apart from that, the mail and sound hooks are fine. The cleantext should
eventually be in a spell, as it definitely won't get included and the
term_title one should be trimmed down, since about half of the functions are
redundant.

The calls to init_hooks look fine.

There's plenty of misformatting; some as a regression.

--
Configure bugmail: http://bugs.sourcemage.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.




Archive powered by MHonArc 2.6.24.

Top of Page