Skip to Content.
Sympa Menu

sm-sorcery-bugs - [SM-Sorcery-Bugs] [Bug 10190] gaze where -path support

sm-sorcery-bugs AT lists.ibiblio.org

Subject: Bugs for Sorcery are reported here

List archive

Chronological Thread  
  • From: bugzilla-daemon AT bugs.sourcemage.org
  • To: sm-sorcery-bugs AT lists.ibiblio.org
  • Subject: [SM-Sorcery-Bugs] [Bug 10190] gaze where -path support
  • Date: 11 Dec 2005 17:52:23 -0000

http://bugs.sourcemage.org/show_bug.cgi?id=10190





------- Additional Comments From acedit AT armory.com 2005-12-11 11:52 -------
this patch needs some work

SHOW_PATH=0 is confusing, if its set it should be non-zero, or you should use
a
-n/-z based comparison.

This is a waste, use an else:
+ SECTION=$(codex_get_spell_section_name $spell)
+ if [[ $SHOW_PATH == 0 ]]; then
+ SECTION="$(codex_find_section_by_name $SECTION)"
+ fi

Please use something more obvious than ${foo:+/bar}. You could just set
SECTION
in the if/else above.
+ message "$spell -> $SECTION${SHOW_PATH:+/$spell}"

Please include manual updates in the patch.

--
Configure bugmail: http://bugs.sourcemage.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.




Archive powered by MHonArc 2.6.24.

Top of Page