Skip to Content.
Sympa Menu

sm-sorcery-bugs - [SM-Sorcery-Bugs] [Bug 2054] added gzip compression option

sm-sorcery-bugs AT lists.ibiblio.org

Subject: Bugs for Sorcery are reported here

List archive

Chronological Thread  
  • From: bugzilla-daemon AT metalab.unc.edu
  • To: sm-sorcery-bugs AT lists.ibiblio.org
  • Subject: [SM-Sorcery-Bugs] [Bug 2054] added gzip compression option
  • Date: Tue, 16 Mar 2004 13:55:55 -0500

http://bugs.sourcemage.org/show_bug.cgi?id=2054





------- Additional Comments From eric AT sandall.us 2004-03-16 13:55 -------
Created an attachment (id=2873)
--> (http://bugs.sourcemage.org/attachment.cgi?id=2873&action=view)
libsorcery.patch

Test bzip2 and gzip; all archived and resurrected fine.

root@isp39:~# ls -lah /var/cache/sorcery/tree*
-rw-r--r-- 1 root root 21K 2004-03-16 10:32
/var/cache/sorcery/tree-1.4b3-i686-pc-linux-gnu.tar.bz2
-rw-r--r-- 1 root root 21K 2004-03-16 10:27
/var/cache/sorcery/tree-1.4b3-i686-pc-linux-gnu.tar.gz

tar did not work:
root@isp39:~# cast -c tree
Creating tree of already cast spells... done
Preparing environment for tree
Collating dependancies...
Spells are to be cast:
---------------------------
tree

Do you want to cast these spells? [y]

make: Circular automake <- autoconf dependency dropped.
make: Circular flex <- bison dependency dropped.
Waiting for any Solo casts to complete...
Waiting for any other casts of tree to complete... done.
Building tree
Unpacking source file tree-1.4b3.tgz for spell tree.
Using gcc version: 3.3.3
Installing in dir: /usr/src/tree-1.4
tree 1.4b3
Creating /var/log/sorcery/compile/tree-1.4b3
Creating install log /var/log/sorcery/install/tree-1.4b3
Creating /var/cache/sorcery/tree-1.4b3-i686-pc-linux-gnu.tar
tar: unrecognized option `--tar'
Try `tar --help' for more information.

The problem is libsorcyer:1544, where it uses:
tar --no-recursion --"$COMPRESSBIN" -cPf "$CACHE_COMP" -T $INST_LOG

In libsorycer:1845:
T) modify_local_config "COMPRESSBIN" "tar" &&
COMPRESSBIN="tar" &&
modify_local_config "EXTENSION" "" ;;

So the command would try:
tar --no-recursion --tar -cPf "$CACHE_COMP" -T $INST_LOG
And tar does not know how to use "tar" for compression.

I've attached a patch against libsorcery of Sorcery 20040316 to fix it.

root@isp39:~# ls -lah /var/cache/sorcery/tree*
-rw-r--r-- 1 root root 60K 2004-03-16 10:48
/var/cache/sorcery/tree-1.4b3-i686-pc-linux-gnu.tar
-rw-r--r-- 1 root root 21K 2004-03-16 10:51
/var/cache/sorcery/tree-1.4b3-i686-pc-linux-gnu.tar.bz2
-rw-r--r-- 1 root root 21K 2004-03-16 10:52
/var/cache/sorcery/tree-1.4b3-i686-pc-linux-gnu.tar.gz

How will `gaze prune` handle these? What if someone partway switches to gzip
after using bzip2 for a while? When they recast a spell, will it only look for
the .gz version and if it can't find it, recast (even though a .bzip2 or .tar
may exist)? Perhaps we should have it first check for the default compression,
and if it doesn't find one of that, check the other two types, and only /then/
recast instead of resurrect.



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.




Archive powered by MHonArc 2.6.24.

Top of Page