Public SourceMage Discussion List

[Ismael Luceno <ismael.luceno AT gmail.com>]

On Wed, 2 Jul 2014 12:15:10 -0400
Paul Vinogradov <vin.public AT gmail.com> wrote:
> Why short names for local variables?

No reason... would it be better if I rename those to something like
spell_branch_var and spell_autoupdate_var?

> 
> В Wed, 2 Jul 2014 12:03:59 -0300
> Ismael Luceno <ismael.luceno AT gmail.com> пишет:
>  
> > Meant number, not name. Anyway...
> > 
> > I'm hoping to slowly clean up the grimoire of all the redundancy.
> > Anyone against this patch? 
> > 
> > On Wed, 2 Jul 2014 08:36:04 -0300
> > Ismael Luceno <ismael.luceno AT gmail.com> wrote:
> > > --- a/FUNCTIONS
> > > +++ b/FUNCTIONS
> > > @@ -662,6 +662,17 @@ function get_up_spell_name() {
> > >    echo ${1:-$SPELL} | tr "a-z-" "A-Z_"
> > >  }
> > >  
> > > +#---
> > > +## Get branch-based/autoupdate-aware version name
> > > +#---
> > > +function get_scm_version() {
> > > +  local spell=$(get_up_spell_name) &&
> > > +  local vers="$spell"_BRANCH &&
> > > +  local au="$spell"_AUTOUPDATE &&
> > > +  echo "${!vers:-scm}$([[ "${!au}" = y ]] && date "+-%Y%m%d")"
> > > +}
> > > +
> > > +
> > >  # Move SPELL_OPTS to OPTS
> > >  # basicly generic OPTS="$SPELL_OPTS $OPTS"
> > >  function prepare_opts() {
> > 
> 
>

Attachment: signature.asc
Description: PGP signature