Public SourceMage Discussion List

[Jason Flatt <jflatt AT sourcemage.org>]

I've been attempting to create some new spells, and in the process I've run 
into a possible bug.  I wanted to run it by the developers before I just 
start making changes, because it seems to me that it should have been found 
before now.

What it is is an include file provided by xmms that seems to have an extra 
semi-colon (;) in it.

The file is /usr/include/xmms/xmmsctrl.h and the line is 88.  Below is the 
file in question.  The offending area is at the end and is excerpted here:
#ifdef __cplusplus
};
#endif

Removing that semi-colon allowed the app (superkaramba in this case) to cast 
to completion. The question is, is this an actual bug and should I proceed 
through the appropriate steps, or is this just some weird anomaly?


/*  XMMS - Cross-platform multimedia player
 *  Copyright (C) 1998-2003  Peter Alm, Mikael Alm, Olle Hallnas,
 *                           Thomas Nilsson and 4Front Technologies
 *  Copyright (C) 1999-2003  Haavard Kvaalen
 *
 *  This program is free software; you can redistribute it and/or modify
 *  it under the terms of the GNU General Public License as published by
 *  the Free Software Foundation; either version 2 of the License, or
 *  (at your option) any later version.
 *
 *  This program is distributed in the hope that it will be useful,
 *  but WITHOUT ANY WARRANTY; without even the implied warranty of
 *  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 *  GNU General Public License for more details.
 *
 *  You should have received a copy of the GNU General Public License
 *  along with this program; if not, write to the Free Software
 *  Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA.
 */
#ifndef XMMS_XMMSCTRL_H
#define XMMS_XMMSCTRL_H

#include <glib.h>

#ifdef __cplusplus
extern "C" {
#endif

gint xmms_connect_to_session(gint session);     /* Do NOT use this! This is 
only 
for control socket initialization now. */
void xmms_remote_playlist(gint session, gchar ** list, gint num, gboolean 
enqueue);
gint xmms_remote_get_version(gint session);
void xmms_remote_playlist_add(gint session, GList * list);
void xmms_remote_playlist_delete(gint session, gint pos);
void xmms_remote_play(gint session);
void xmms_remote_pause(gint session);
void xmms_remote_stop(gint session);
gboolean xmms_remote_is_playing(gint session);
gboolean xmms_remote_is_paused(gint session);
gint xmms_remote_get_playlist_pos(gint session);
void xmms_remote_set_playlist_pos(gint session, gint pos);
gint xmms_remote_get_playlist_length(gint session);
void xmms_remote_playlist_clear(gint session);
gint xmms_remote_get_output_time(gint session);
void xmms_remote_jump_to_time(gint session, gint pos);
void xmms_remote_get_volume(gint session, gint * vl, gint * vr);
gint xmms_remote_get_main_volume(gint session);
gint xmms_remote_get_balance(gint session);
void xmms_remote_set_volume(gint session, gint vl, gint vr);
void xmms_remote_set_main_volume(gint session, gint v);
void xmms_remote_set_balance(gint session, gint b);
gchar *xmms_remote_get_skin(gint session);
void xmms_remote_set_skin(gint session, gchar * skinfile);
gchar *xmms_remote_get_playlist_file(gint session, gint pos);
gchar *xmms_remote_get_playlist_title(gint session, gint pos);
gint xmms_remote_get_playlist_time(gint session, gint pos);
void xmms_remote_get_info(gint session, gint * rate, gint * freq, gint * nch);
void xmms_remote_main_win_toggle(gint session, gboolean show);
void xmms_remote_pl_win_toggle(gint session, gboolean show);
void xmms_remote_eq_win_toggle(gint session, gboolean show);
gboolean xmms_remote_is_main_win(gint session);
gboolean xmms_remote_is_pl_win(gint session);
gboolean xmms_remote_is_eq_win(gint session);
void xmms_remote_show_prefs_box(gint session);
void xmms_remote_toggle_aot(gint session, gboolean ontop);
void xmms_remote_eject(gint session);
void xmms_remote_playlist_prev(gint session);
void xmms_remote_playlist_next(gint session);
void xmms_remote_playlist_add_url_string(gint session, gchar * string);
gboolean xmms_remote_is_running(gint session);
void xmms_remote_toggle_repeat(gint session);
void xmms_remote_toggle_shuffle(gint session);
gboolean xmms_remote_is_repeat(gint session);
gboolean xmms_remote_is_shuffle(gint session);
void xmms_remote_get_eq(gint session, gfloat *preamp, gfloat **bands);
gfloat xmms_remote_get_eq_preamp(gint session);
gfloat xmms_remote_get_eq_band(gint session, gint band);
void xmms_remote_set_eq(gint session, gfloat preamp, gfloat *bands);
void xmms_remote_set_eq_preamp(gint session, gfloat preamp);
void xmms_remote_set_eq_band(gint session, gint band, gfloat value);
/* Added in XMMS 1.2.1 */
void xmms_remote_quit(gint session);
/* Added in XMMS 1.2.6 */
void xmms_remote_play_pause(gint session);
void xmms_remote_playlist_ins_url_string(gint session, gchar * string, gint 
pos);

        
#ifdef __cplusplus
};
#endif

/* Deprecated APIs */
void xmms_remote_play_files(gint session, GList * list);

#define xmms_remote_add_files(session,list) \
        xmms_remote_playlist_add(session,list)


#endif


-- 
Jason Flatt
Source Mage GNU/Linux: Linux so advanced, it may as well be magic.
http://www.sourcemage.org/
jflatt AT sourcemage.org

Attachment: pgpMZio9f379R.pgp
Description: PGP signature