Public SourceMage Discussion List

[Andrew <afrayedknot AT thefrayedknot.armory.com>]

On Thu, Jun 24, 2004 at 03:38:30PM -0700, Seth Alan Woolley wrote:
> On Thu, Jun 24, 2004 at 02:24:29PM -0700, Andrew wrote:
> > On Thu, Jun 24, 2004 at 01:37:31PM -0700, Seth Alan Woolley wrote:
> > > Might we just have a DISTRIBUTABLE[0]=no variable in details only for
> > > those spell files that aren't?  Summon could pick up on this and 400 the
> > > source file automatically.  This seems the most natural because the
> > > permissions would be more "truthful".  If I have a public shell server,
> > > for example, I wouldn't want somebody getting access to the file just
> > > because summon isn't smart enough.
> > > 
> > > Also where does summon put the files before it is completely downloaded
> > > and what permissions are given the temporary file?
> > > 
> > 
> > Okay if you really think its necessary, file a bug and I'll get to it.
> > Someone will of course need to set this distributable flag on all spells
> > that need it set to no.
> > 
> > The files usually get downloaded to /tmp although im not 100% certain
> > of that for all url handlers. The mechanism is that the url handler
> > downloads the file wherever it wants and then sets FILE to whatever that
> > was, then libdownload goes and puts it in the right name and place.
> 
> If you'd rather I made the change, I think I can manage it, since it's
> really for me.  I think this is the first z-rejected spell where the
> binary is download restricted, I know j2sdk's source is, for practical
> purposes, download restricted as well.
> 
Sure, I think the change best fits into libdownload.download_files around
line 139. You'll need to do a little more work changing the permissions
and before it runs mv, there are some corner cases in there I've just not
dealt with too, but you could probably just run something like:

local DISTRIBUTABLE=${DISTRIBUTABLE:-yes}
[ "$DISTRIBUTABLE" == "no" ] &&
chmod 400 $FILE

And always, test test test :)

-Andrew


-- 
__________________________________________________________________________
|Andrew D. Stitt                           | astitt at sourcemage.org    |
|irc: afrayedknot                          | afrayedknot at t.armory.com |
|aim: thefrayedknot or iteratorplusplus    |                             |
|Sorcery Team Lead, Porting Team Lead      |                             |
|Grimoire Guru ham/smgl                    | ftp://t.armory.com          |
|Author and Maintainer of Prometheus       |                             |
--------------------------------------------------------------------------