Source Mage code commit list

[Pavel Vinogradov <vin.public AT gmail.com>]

Just to make sure we have extra delimiters to prevent future typos/bugs. (I
hope)

As of readability: it's very subjective, for me braces help to distinguish
variables in long consecutive cases.

On Sun, Jul 17, 2016 at 12:25:46PM +0200, Thomas Orgis wrote:
> Am Sat, 16 Jul 2016 17:09:53 +0000
> schrieb Pavel Vinogradov <scm AT sourcemage.org>:
>
> > -SOURCE_DIRECTORY=$BUILD_DIRECTORY/mesa-$VERSION
> > -          SOURCE=$SX.tar.xz
> > -   SOURCE_URL[0]=ftp://ftp.freedesktop.org/pub/mesa/${VERSION}/$SOURCE
> > +SOURCE_DIRECTORY=$BUILD_DIRECTORY/${SX}
> > +          SOURCE=${SX}.tar.xz
> > +   SOURCE_URL[0]=ftp://ftp.freedesktop.org/pub/mesa/${VERSION}/${SOURCE}
>
> Why not dropping the unnecessary ${BRACES} instead?
>
> +SOURCE_DIRECTORY=$BUILD_DIRECTORY/$SX
> +          SOURCE=$SX.tar.xz
> +   SOURCE_URL[0]=ftp://ftp.freedesktop.org/pub/mesa/$VERSION/$SOURCE
>
> More readable and just the same.
>
>
> Alrighty then,
>
> Thomas



--
Sincerely,
Pavel Vinogradov

Attachment: signature.asc
Description: PGP signature