Skip to Content.
Sympa Menu

sm-commit - Re: [SM-Commit] GIT changes to master grimoire by Pavel Vinogradov (dcefcbdd11c9e4ea686b43b1c66173c2e2f2036e)

sm-commit AT lists.ibiblio.org

Subject: Source Mage code commit list

List archive

Chronological Thread  
  • From: Pavel Vinogradov <vin.public AT gmail.com>
  • To: sm-commit AT lists.ibiblio.org
  • Subject: Re: [SM-Commit] GIT changes to master grimoire by Pavel Vinogradov (dcefcbdd11c9e4ea686b43b1c66173c2e2f2036e)
  • Date: Sun, 17 Jul 2016 11:22:14 -0400

Just to make sure we have extra delimiters to prevent future typos/bugs. (I
hope)

As of readability: it's very subjective, for me braces help to distinguish
variables in long consecutive cases.

On Sun, Jul 17, 2016 at 12:25:46PM +0200, Thomas Orgis wrote:
Am Sat, 16 Jul 2016 17:09:53 +0000
schrieb Pavel Vinogradov <scm AT sourcemage.org>:

-SOURCE_DIRECTORY=$BUILD_DIRECTORY/mesa-$VERSION
- SOURCE=$SX.tar.xz
- SOURCE_URL[0]=ftp://ftp.freedesktop.org/pub/mesa/${VERSION}/$SOURCE
+SOURCE_DIRECTORY=$BUILD_DIRECTORY/${SX}
+ SOURCE=${SX}.tar.xz
+ SOURCE_URL[0]=ftp://ftp.freedesktop.org/pub/mesa/${VERSION}/${SOURCE}

Why not dropping the unnecessary ${BRACES} instead?

+SOURCE_DIRECTORY=$BUILD_DIRECTORY/$SX
+ SOURCE=$SX.tar.xz
+ SOURCE_URL[0]=ftp://ftp.freedesktop.org/pub/mesa/$VERSION/$SOURCE

More readable and just the same.


Alrighty then,

Thomas



--
Sincerely,
Pavel Vinogradov

Attachment: signature.asc
Description: PGP signature




Archive powered by MHonArc 2.6.24.

Top of Page