sm-commit AT lists.ibiblio.org
Subject: Source Mage code commit list
List archive
Re: [SM-Commit] GIT changes to master grimoire by Treeve Jelbert (58129e6b8857bf1d0e166f8f9e94c4a332742249)
- From: Thomas Orgis <thomas-forum AT orgis.org>
- To: Treeve Jelbert <scm AT sourcemage.org>
- Cc: sm-commit AT lists.ibiblio.org
- Subject: Re: [SM-Commit] GIT changes to master grimoire by Treeve Jelbert (58129e6b8857bf1d0e166f8f9e94c4a332742249)
- Date: Thu, 23 Jul 2015 08:49:42 +0200
Sorry for responding so late, but …
Am Sun, 19 Jul 2015 18:43:00 +0000
schrieb Treeve Jelbert <scm AT sourcemage.org>:
> commit 026cd74068aa0db9b8f722830d241d314f492520
> Author: Treeve Jelbert <treeve AT sourcemage.org>
> Commit: Treeve Jelbert <treeve AT sourcemage.org>
>
> libaccounts-glib: => master
>
> diff --git a/accounts-sso/libaccounts-glib/DETAILS
> b/accounts-sso/libaccounts-glib/DETAILS
> index c4efca4..c08cf40 100755
> --- a/accounts-sso/libaccounts-glib/DETAILS
> +++ b/accounts-sso/libaccounts-glib/DETAILS
> @@ -1,5 +1,5 @@
> SPELL=libaccounts-glib
> - VERSION=1.18
> + VERSION=master
> SOURCE_DIRECTORY=$BUILD_DIRECTORY/$SPELL
> WEB_SITE=https://gitlab.com/accounts-sso/$SPELL
> SOURCE_URL[0]=$WEB_SITE.git
> @@ -8,7 +8,10 @@ SOURCE_DIRECTORY=$BUILD_DIRECTORY/$SPELL
> KEYWORDS=""
> SHORT=""
> cat << EOF
Could you please
a) refer to a specific revision instead of master, moving target
versions as default are not good,
b) exlain to me how this is supposed to work at all?
I realize I am not familiar how sorcery works out this kind of spell.
SOURCE_URL is a git repo, the VERSION points to a branch? Is it downloading
https://gitlab.com/accounts-sso/libaccounts-glib/repository/archive.tar.bz2?ref=master
(and previously,
https://gitlab.com/accounts-sso/libaccounts-glib/repository/archive.tar.bz2?ref=VERSION_1.18
)? If so, why not using simply that URL? This eases mirroring things.
But still, one needs to provide a source file name.
I tested with sorcery-{stable,test,devel} and summon did nothing for
libaccounts-glib. So I suspect the spell is incomplete or you have some
local sorcery hacks in place to magically work with this.
Really, I wonder: is this a complete spell at all?
Alrighty then,
Thomas
PS: The tarball resulting from such an URL still just contains a
directory named libaccounts-glib.git/. That is unfortunate. People
shouldn't be too lazy to do dammed releases!?!! Even using VERSION_1.18
is not safe. This is a branch which can change any day. We need to
refer to a specific commit at least. Then we can add a checksum to
DETAILS. I very much like checksums in DETAILS.
Attachment:
pgp5gJk1xHSDg.pgp
Description: Digitale Signatur von OpenPGP
-
[SM-Commit] GIT changes to master grimoire by Treeve Jelbert (58129e6b8857bf1d0e166f8f9e94c4a332742249),
Treeve Jelbert, 07/19/2015
- Re: [SM-Commit] GIT changes to master grimoire by Treeve Jelbert (58129e6b8857bf1d0e166f8f9e94c4a332742249), Thomas Orgis, 07/23/2015
Archive powered by MHonArc 2.6.24.